[Scummvm-git-logs] scummvm master -> 11d8771cf0599dd785bf456c8a16644822477f70
bluegr
noreply at scummvm.org
Sun May 21 08:27:59 UTC 2023
This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .
Summary:
11d8771cf0 GROOVIE: Don't use uninitialized variable in triangle game logic
Commit: 11d8771cf0599dd785bf456c8a16644822477f70
https://github.com/scummvm/scummvm/commit/11d8771cf0599dd785bf456c8a16644822477f70
Author: Filippos Karapetis (bluegr at gmail.com)
Date: 2023-05-21T11:27:47+03:00
Commit Message:
GROOVIE: Don't use uninitialized variable in triangle game logic
Changed paths:
engines/groovie/logic/triangle.cpp
diff --git a/engines/groovie/logic/triangle.cpp b/engines/groovie/logic/triangle.cpp
index cb64e51f804..9075fd69a4e 100644
--- a/engines/groovie/logic/triangle.cpp
+++ b/engines/groovie/logic/triangle.cpp
@@ -167,7 +167,7 @@ int8 TriangleGame::sub03(int8 player) {
pos = pickedMoves[_random.getRandomNumber(max - 1)];
else {
warning("TriangleGame: Undefined behaviour");
- pos = tempMoves[0]; // This is uninitalized in this branch
+ pos = 0; // tempMoves is uninitalized in this branch, so just return 0
}
}
More information about the Scummvm-git-logs
mailing list