[Scummvm-git-logs] scummvm-web master -> 3807a83203679fb13a4d9e03d62e4badb952a2b1

Thunderforge noreply at scummvm.org
Fri May 26 05:22:15 UTC 2023


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm-web' repo located at https://github.com/scummvm/scummvm-web .

Summary:
3807a83203 WEB: Using simple replace for support description (#298)


Commit: 3807a83203679fb13a4d9e03d62e4badb952a2b1
    https://github.com/scummvm/scummvm-web/commit/3807a83203679fb13a4d9e03d62e4badb952a2b1
Author: Thunderforge (wjherrmann at gmail.com)
Date: 2023-05-26T00:22:11-05:00

Commit Message:
WEB: Using simple replace for support description (#298)

Fixes issue #13720.

The old system used a placeholder and was overbroad in its regex replace for that placeholder, which garbled links. Since we don't need a special regex for a placeholder, this does the job in a simpler and more reliable way.

Changed paths:
    include/OrmObjects/Compatibility.php
    templates/components/compatibility_details.tpl


diff --git a/include/OrmObjects/Compatibility.php b/include/OrmObjects/Compatibility.php
index 4b261116..edcdafee 100644
--- a/include/OrmObjects/Compatibility.php
+++ b/include/OrmObjects/Compatibility.php
@@ -42,7 +42,7 @@ class Compatibility extends BaseCompatibility
     public function getNotes()
     {
         $notes = "### Support Level\n\n";
-        $notes .= "%{$this->getSupport()}%\n\n";
+        $notes .= "[[support_description]]\n\n";
 
         if ($stable = $this->getStablePlatforms()) {
             $notes .= "### Supported Platforms \n";
diff --git a/templates/components/compatibility_details.tpl b/templates/components/compatibility_details.tpl
index a9715467..0d402cee 100644
--- a/templates/components/compatibility_details.tpl
+++ b/templates/components/compatibility_details.tpl
@@ -21,7 +21,7 @@
         </tr>
         <tr class="color2">
             <td colspan="3" class="details">
-                {$game->getNotes()|regex_replace:"/%.+%/":$support_description}
+                {$game->getNotes()|replace:"[[support_description]]":$support_description}
             </td>
         </tr>
     </tbody>




More information about the Scummvm-git-logs mailing list