[Scummvm-git-logs] scummvm master -> 6341222419951f2a5fc3874f816634c8115b87c4

[AndywinXp]

This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
6341222419 SCUMM: INDY4 (DOS/Mac Jap): Disable drawing for hidden character


Commit: 6341222419951f2a5fc3874f816634c8115b87c4
    https://github.com/scummvm/scummvm/commit/6341222419951f2a5fc3874f816634c8115b87c4
Author: AndywinXp (andywinxp at gmail.com)
Date: 2023-11-12T20:03:58+01:00

Commit Message:
SCUMM: INDY4 (DOS/Mac Jap): Disable drawing for hidden character

Changed paths:
    engines/scumm/charset.cpp


diff --git a/engines/scumm/charset.cpp b/engines/scumm/charset.cpp
index ecca27e0047..53e46a873fb 100644
--- a/engines/scumm/charset.cpp
+++ b/engines/scumm/charset.cpp
@@ -1050,6 +1050,15 @@ void CharsetRendererClassic::printChar(int chr, bool ignoreCharsetMask) {
 	if (chr == '@')
 		return;
 
+	// This is an actual check from disasm:
+	// it appears that a certain Japanese glyph was previously being drawn with the '_' character.
+	// The executable now disables any attempt to draw this character. Removing this check draws
+	// an additional '_' character where it should be drawn.
+	// This, of course, disables the text cursor when writing a savegame name, but that's in the
+	// original as well.
+	if (_vm->_isIndy4Jap && chr == '_')
+		return;
+
 	translateColor();
 
 	_vm->_charsetColorMap[1] = _color;