[Scummvm-git-logs] scummvm master -> 2924c537a1dac17a836b188e1d75ed170c340f12

[hax0kartik]

This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
2924c537a1 CRAB: Use move instead of copy where possible as reported by Coverity


Commit: 2924c537a1dac17a836b188e1d75ed170c340f12
    https://github.com/scummvm/scummvm/commit/2924c537a1dac17a836b188e1d75ed170c340f12
Author: Kartik Agarwala (agarwala.kartik at gmail.com)
Date: 2023-11-20T15:43:37+05:30

Commit Message:
CRAB: Use move instead of copy where possible as reported by Coverity

Changed paths:
    engines/crab/GameParam.cpp
    engines/crab/TMX/TMXMap.cpp
    engines/crab/TMX/TMXMap.h


diff --git a/engines/crab/GameParam.cpp b/engines/crab/GameParam.cpp
index 203c31b6638..7d06163c2ea 100644
--- a/engines/crab/GameParam.cpp
+++ b/engines/crab/GameParam.cpp
@@ -70,7 +70,7 @@ void FilePaths::loadLevel(const Common::String &filename) {
 			Common::String id;
 			loadStr(id, "id", n);
 
-			_level[id] = l;
+			_level[id] = Common::move(l);
 		}
 	}
 }
diff --git a/engines/crab/TMX/TMXMap.cpp b/engines/crab/TMX/TMXMap.cpp
index 06f6837840a..99ca5efed88 100644
--- a/engines/crab/TMX/TMXMap.cpp
+++ b/engines/crab/TMX/TMXMap.cpp
@@ -61,7 +61,7 @@ TMXMap::TMXMap() {
 // Purpose: Load stuff via a .tmx file set to xml storage (no compression)
 //------------------------------------------------------------------------
 
-void TMXMap::load(const Common::String &path, Common::String filename) {
+void TMXMap::load(const Common::String &path, const Common::String &filename) {
 	XMLDoc conf((path + filename));
 	if (conf.ready()) {
 		rapidxml::xml_node<char> *node = conf.doc()->first_node("map");
diff --git a/engines/crab/TMX/TMXMap.h b/engines/crab/TMX/TMXMap.h
index 4643944d295..4ba61663897 100644
--- a/engines/crab/TMX/TMXMap.h
+++ b/engines/crab/TMX/TMXMap.h
@@ -104,7 +104,7 @@ public:
 	~TMXMap() {}
 
 	void reset();
-	void load(const Common::String &path, Common::String filename);
+	void load(const Common::String &path, const Common::String &filename);
 
 	void drawDebug(const Rect &camera);