[Scummvm-git-logs] scummvm master -> 39d60856aaca25a2a609b7f15727e0f6aced592b

mgerhardy noreply at scummvm.org
Mon Oct 2 14:54:17 UTC 2023


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
39d60856aa TWINE: the movement of the meca penguin is different from dos version


Commit: 39d60856aaca25a2a609b7f15727e0f6aced592b
    https://github.com/scummvm/scummvm/commit/39d60856aaca25a2a609b7f15727e0f6aced592b
Author: Martin Gerhardy (martin.gerhardy at gmail.com)
Date: 2023-10-01T20:58:16+02:00

Commit Message:
TWINE: the movement of the meca penguin is different from dos version

Changed paths:
    engines/twine/twine.cpp


diff --git a/engines/twine/twine.cpp b/engines/twine/twine.cpp
index 5809cbcedb6..a8793da3f70 100644
--- a/engines/twine/twine.cpp
+++ b/engines/twine/twine.cpp
@@ -750,6 +750,12 @@ void TwinEEngine::processInventoryAction() {
 		penguin->_pos = _scene->_sceneHero->posObj();
 		penguin->_pos.x += destPos.x;
 		penguin->_pos.z += destPos.y;
+		// TODO: HACK for https://bugs.scummvm.org/ticket/13731
+		// The movement of the meca penguin is different from dos version
+		// the problem is that the value set to 1 even if the penguin is not yet spawned
+		// this might either be a problem with initObject() not being called for the penguin
+		// or some other flaw that doesn't ignore the penguin until spawned
+		penguin->_dynamicFlags.bIsFalling = 0;
 
 		penguin->_beta = _scene->_sceneHero->_beta;
 		debug("penguin angle: %i", penguin->_beta);




More information about the Scummvm-git-logs mailing list