[Scummvm-git-logs] scummvm master -> 781fabac28fe0213af104ba3411c0044b9f9aace

digitall noreply at scummvm.org
Sun Oct 15 19:38:17 UTC 2023


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
781fabac28 COMMON: Fix Signed vs. Unsigned GCC Compiler Warning in Cue Sheet Parser


Commit: 781fabac28fe0213af104ba3411c0044b9f9aace
    https://github.com/scummvm/scummvm/commit/781fabac28fe0213af104ba3411c0044b9f9aace
Author: D G Turner (digitall at scummvm.org)
Date: 2023-10-15T20:37:16+01:00

Commit Message:
COMMON: Fix Signed vs. Unsigned GCC Compiler Warning in Cue Sheet Parser

This should now be fixed irrespective of whether size_t is signed or not.

Changed paths:
    common/formats/cue.cpp


diff --git a/common/formats/cue.cpp b/common/formats/cue.cpp
index ed73721068e..14ef4a6acc3 100644
--- a/common/formats/cue.cpp
+++ b/common/formats/cue.cpp
@@ -252,7 +252,7 @@ void CueSheet::parseFilesContext(const char *line) {
 		if (trackNum < 0 || (_currentTrack > 0 && _currentTrack + 1 != trackNum)) {
 			warning("CueSheet: Incorrect track number. Expected %d but got %d at line %d", _currentTrack + 1, trackNum, _lineNum);
 		} else {
-			for (uint i = _files[_currentFile].tracks.size(); i <= trackNum; i++)
+			for (int i = (int)_files[_currentFile].tracks.size(); i <= trackNum; i++)
 				_files[_currentFile].tracks.push_back(CueTrack());
 
 			_currentTrack = trackNum;
@@ -292,7 +292,7 @@ void CueSheet::parseTracksContext(const char *line) {
 		int indexNum = atoi(nexttok(s, &s).c_str());
 		int frames = parseMSF(nexttok(s, &s).c_str());
 
-		for (uint i = _files[_currentFile].tracks[_currentTrack].indices.size(); i <= indexNum; i++)
+		for (int i = (int)_files[_currentFile].tracks[_currentTrack].indices.size(); i <= indexNum; i++)
 			_files[_currentFile].tracks[_currentTrack].indices.push_back(0);
 
 		_files[_currentFile].tracks[_currentTrack].indices[indexNum] = frames;




More information about the Scummvm-git-logs mailing list