[Scummvm-git-logs] scummvm master -> c2249aacfad8d9b73104dd12049533c4601807d1

LittleToonCat noreply at scummvm.org
Wed Oct 18 00:54:18 UTC 2023


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
c2249aacfa HE SCUMM: Fix identical sub-expressions.  PVS-Studio V501


Commit: c2249aacfad8d9b73104dd12049533c4601807d1
    https://github.com/scummvm/scummvm/commit/c2249aacfad8d9b73104dd12049533c4601807d1
Author: Little Cat (toontownlittlecat at gmail.com)
Date: 2023-10-17T21:54:06-03:00

Commit Message:
HE SCUMM: Fix identical sub-expressions.  PVS-Studio V501

Changed paths:
    engines/scumm/he/net/net_main.cpp


diff --git a/engines/scumm/he/net/net_main.cpp b/engines/scumm/he/net/net_main.cpp
index 55ff7f465ce..96ecc46cbe6 100644
--- a/engines/scumm/he/net/net_main.cpp
+++ b/engines/scumm/he/net/net_main.cpp
@@ -427,7 +427,7 @@ int Net::endSession() {
 		_isShuttingDown = true;
 		// Send out any remaining data from the queue before shutting down.
 		while (_hostDataQueue.size()) {
-			if (_hostDataQueue.size() != _hostDataQueue.size())
+			if (_hostDataQueue.size() != _peerIndexQueue.size())
 				warning("NETWORK: Sizes of data and peer index queues does not match!  Expect some wonky stuff");
 			Common::JSONValue *json = _hostDataQueue.pop();
 			int peerIndex = _peerIndexQueue.pop();
@@ -1265,7 +1265,7 @@ void Net::doNetworkOnceAFrame(int msecs) {
 		serviceBroadcast();
 
 	if (_isHost && _hostDataQueue.size()) {
-		if (_hostDataQueue.size() != _hostDataQueue.size())
+		if (_hostDataQueue.size() != _peerIndexQueue.size())
 			warning("NETWORK: Sizes of data and peer index queues does not match!  Expect some wonky stuff");
 		Common::JSONValue *json = _hostDataQueue.pop();
 		int peerIndex = _peerIndexQueue.pop();




More information about the Scummvm-git-logs mailing list