[Scummvm-git-logs] scummvm master -> f499a25c98dbc8a8ad8066f3873bcf31608d5f68

[lephilousophe]

This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
f499a25c98 BACKENDS: CLOUD: Remove last pass-by value arguments


Commit: f499a25c98dbc8a8ad8066f3873bcf31608d5f68
    https://github.com/scummvm/scummvm/commit/f499a25c98dbc8a8ad8066f3873bcf31608d5f68
Author: Le Philousophe (lephilousophe at users.noreply.github.com)
Date: 2023-10-30T10:49:36+01:00

Commit Message:
BACKENDS: CLOUD: Remove last pass-by value arguments

This is a follow up of #5337

Changed paths:
    backends/cloud/dropbox/dropboxuploadrequest.cpp
    backends/cloud/dropbox/dropboxuploadrequest.h
    backends/cloud/googledrive/googledriveuploadrequest.cpp
    backends/cloud/googledrive/googledriveuploadrequest.h


diff --git a/backends/cloud/dropbox/dropboxuploadrequest.cpp b/backends/cloud/dropbox/dropboxuploadrequest.cpp
index dafdf1443e9..ef639d69ccd 100644
--- a/backends/cloud/dropbox/dropboxuploadrequest.cpp
+++ b/backends/cloud/dropbox/dropboxuploadrequest.cpp
@@ -195,7 +195,7 @@ void DropboxUploadRequest::handle() {}
 
 void DropboxUploadRequest::restart() { start(); }
 
-void DropboxUploadRequest::finishUpload(StorageFile file) {
+void DropboxUploadRequest::finishUpload(const StorageFile &file) {
 	Request::finishSuccess();
 	if (_uploadCallback)
 		(*_uploadCallback)(Storage::UploadResponse(this, file));
diff --git a/backends/cloud/dropbox/dropboxuploadrequest.h b/backends/cloud/dropbox/dropboxuploadrequest.h
index cf74612d810..9ea3b3af48d 100644
--- a/backends/cloud/dropbox/dropboxuploadrequest.h
+++ b/backends/cloud/dropbox/dropboxuploadrequest.h
@@ -45,7 +45,7 @@ class DropboxUploadRequest: public Networking::Request {
 	void uploadNextPart();
 	void partUploadedCallback(const Networking::JsonResponse &response);
 	void partUploadedErrorCallback(const Networking::ErrorResponse &error);
-	void finishUpload(StorageFile status);
+	void finishUpload(const StorageFile &status);
 
 public:
 	DropboxUploadRequest(DropboxStorage *storage, const Common::String &path, Common::SeekableReadStream *contents, Storage::UploadCallback callback, Networking::ErrorCallback ecb);
diff --git a/backends/cloud/googledrive/googledriveuploadrequest.cpp b/backends/cloud/googledrive/googledriveuploadrequest.cpp
index e27d543ce31..3d8808305d8 100644
--- a/backends/cloud/googledrive/googledriveuploadrequest.cpp
+++ b/backends/cloud/googledrive/googledriveuploadrequest.cpp
@@ -334,7 +334,7 @@ void GoogleDriveUploadRequest::handle() {}
 
 void GoogleDriveUploadRequest::restart() { start(); }
 
-void GoogleDriveUploadRequest::finishUpload(StorageFile file) {
+void GoogleDriveUploadRequest::finishUpload(const StorageFile &file) {
 	Request::finishSuccess();
 	if (_uploadCallback)
 		(*_uploadCallback)(Storage::UploadResponse(this, file));
diff --git a/backends/cloud/googledrive/googledriveuploadrequest.h b/backends/cloud/googledrive/googledriveuploadrequest.h
index f19419cb65e..a48549552cf 100644
--- a/backends/cloud/googledrive/googledriveuploadrequest.h
+++ b/backends/cloud/googledrive/googledriveuploadrequest.h
@@ -53,7 +53,7 @@ class GoogleDriveUploadRequest: public Networking::Request {
 	void partUploadedCallback(const Networking::JsonResponse &response);
 	void partUploadedErrorCallback(const Networking::ErrorResponse &error);
 	bool handleHttp308(const Networking::NetworkReadStream *stream);
-	void finishUpload(StorageFile status);
+	void finishUpload(const StorageFile &status);
 
 public:
 	GoogleDriveUploadRequest(GoogleDriveStorage *storage, const Common::String &path, Common::SeekableReadStream *contents, Storage::UploadCallback callback, Networking::ErrorCallback ecb);