[Scummvm-git-logs] scummvm master -> 828b501e41cd88b566d4368d34dfe7bf3d9ba02c

[sev-]

This automated email contains information about 2 new commits which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
3093951678 DISTS: ANDROID: Update German store metadata for 2.8.1
828b501e41 ENGINES: Reset palette in the base Engline constructor


Commit: 3093951678a8886bba75237fd2987e3d95acef3a
    https://github.com/scummvm/scummvm/commit/3093951678a8886bba75237fd2987e3d95acef3a
Author: Eugene Sandulenko (sev at scummvm.org)
Date: 2024-04-01T15:21:32+02:00

Commit Message:
DISTS: ANDROID: Update German store metadata for 2.8.1

Changed paths:
    dists/android/store/metadata-de-DE.txt


diff --git a/dists/android/store/metadata-de-DE.txt b/dists/android/store/metadata-de-DE.txt
index e97505e7938..a3b8440d59d 100644
--- a/dists/android/store/metadata-de-DE.txt
+++ b/dists/android/store/metadata-de-DE.txt
@@ -21,13 +21,9 @@ Ebenfalls auf unserer Website findest du unter der URL https://docs.scummvm.org/
 https://forums.scummvm.org/viewforum.php?f=17 ist unser Forum, wo du dich mit anderen Nutzern über die Android-Version austauschen kannst.
 
 *** Current release (limit is 500 characters):
-2.8.0
+2.8.1
 
 *** Release notes:
-- Unterstützung für Bildschirmdrehung hinzugefügt
-- Schaltfläche „Hilfesystem“ auf dem Startbildschirm hinzugefügt
-- Verbesserungen für den direkten Mausmodus
-- Neue Touch-Geste für das Scrollen mit dem Mausrad (mit zwei Fingern scrollen)
-- Gemeldete Abstürze behoben und die Gesamtstabilität verbessert
+- Gemeldete Grafikfehler und App-Abstürze behoben
 
-Vollständige Versionshinweise: https://scummvm.org/frs/scummvm/2.8.0/ReleaseNotes.html
+Vollständige Versionshinweise: https://scummvm.org/frs/scummvm/2.8.1/ReleaseNotes.html


Commit: 828b501e41cd88b566d4368d34dfe7bf3d9ba02c
    https://github.com/scummvm/scummvm/commit/828b501e41cd88b566d4368d34dfe7bf3d9ba02c
Author: Eugene Sandulenko (sev at scummvm.org)
Date: 2024-04-01T15:21:32+02:00

Commit Message:
ENGINES: Reset palette in the base Engline constructor

If some engine is using less that 256 colors, but in its graphics
there are references to higher colors (by whatever reasons), it may
stay unnoticed on platforms that reset newly allocated memory to 0,
e.g. Windows.

On other systems like Mac, it might lead to random graphics artefacts
difficult to reproduce, e.g. due to the uninited memory.

Also, when you return to launcher from an engine, our GUI is not setting
any palette, so even on Windows, the new engine will inherit whatever
palette was set.

This was caught in Loom Mac, which uses 16 colors. Text shadow was
suddenly white instead of black. Steps to reproduce: run samnmax,
load a saved game, return to launcher, run Loom Mac.

It was addressed in 43c3cc69c25ed0df8bff3d44e8fdf53a27246b5a, but
this change makes it generic.

Changed paths:
    engines/engine.cpp


diff --git a/engines/engine.cpp b/engines/engine.cpp
index d6a7a93fe34..03f2dde5729 100644
--- a/engines/engine.cpp
+++ b/engines/engine.cpp
@@ -56,6 +56,7 @@
 
 #include "graphics/cursorman.h"
 #include "graphics/fontman.h"
+#include "graphics/paletteman.h"
 #include "graphics/pixelformat.h"
 #include "image/bmp.h"
 
@@ -181,6 +182,16 @@ Engine::Engine(OSystem *syst)
 	// palettes till the user enables it again.
 	CursorMan.pushCursorPalette(NULL, 0, 0);
 
+	// If we go from engine A to engine B via launcher, the palette
+	// is not touched during this process, since our GUI is 16-bit
+	// or 32-bit.
+	//
+	// This may lead to residual palette entries held in the backedn
+	// from a previous engine. Here we make sure we reset the palette.
+	byte dummyPalette[768];
+	memset(dummyPalette, 0, 768);
+	g_system->getPaletteManager()->setPalette(dummyPalette, 0, 256);
+
 	defaultSyncSoundSettings();
 }