[Scummvm-git-logs] scummvm master -> 006801dcdda1f6134904161cf6aee49113801bad

[sev-]

This automated email contains information about 2 new commits which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
4612fa0160 CONFIGURE: Disable some warnings with GCC < 4.8
006801dcdd CONFIGURE: RISCOS: Avoid -Wformat noise about "GNU extensions" on RISC OS


Commit: 4612fa01608baf37571b11e8759a2f25fc7aa402
    https://github.com/scummvm/scummvm/commit/4612fa01608baf37571b11e8759a2f25fc7aa402
Author: Donovan Watteau (contrib at dwatteau.fr)
Date: 2024-08-14T22:00:15+02:00

Commit Message:
CONFIGURE: Disable some warnings with GCC < 4.8

It looks like some warnings give a lot of false positives in GCC 4.7, often
when dealing with templates. GCC 4.8+ doesn't have this problem, so just
remove the noise, so that real warnings are easier to see.

This primarily covers RISC OS.

Changed paths:
    configure


diff --git a/configure b/configure
index 8794221f27a..fda8b8dd9a0 100755
--- a/configure
+++ b/configure
@@ -2292,6 +2292,15 @@ if test "$have_gcc" = yes; then
 		else
 			append_var CXXFLAGS "-Wno-missing-field-initializers"
 		fi
+
+		# Many false positives before GCC 4.8, e.g. with templates
+		if test $_cxx_major -eq 4 && test $_cxx_minor -le 7; then
+			append_var CXXFLAGS "-Wno-type-limits"
+			append_var CXXFLAGS "-Wno-uninitialized"
+			append_var CXXFLAGS "-Wno-maybe-uninitialized"
+			append_var CXXFLAGS "-Wno-array-bounds"
+		fi
+
 	fi
 elif test "$have_icc" = yes; then
 	cxx_version="`( $CXX -dumpversion ) 2>/dev/null`"
@@ -4741,10 +4750,17 @@ fi
 # Check whether to enable optimizations
 #
 if test "$_optimizations" = yes ; then
-	# Enable optimizations. This also
-	# makes it possible to use -Wuninitialized, so let's do that.
+	# Enable optimizations
 	append_var CXXFLAGS "$_optimization_level"
-	append_var CXXFLAGS "-Wuninitialized"
+
+	# Optimizations make it possible to use -Wuninitialized, so let's do that
+	# (but only when the compiler has a reliable -Wuninitialized, see the
+	# other _cxx_major/_cxx_minor checks above)
+	if test "$have_gcc" = yes && test $_cxx_major -eq 4 && test $_cxx_minor -le 7; then
+		: nothing
+	else
+		append_var CXXFLAGS "-Wuninitialized"
+	fi
 fi
 
 #


Commit: 006801dcdda1f6134904161cf6aee49113801bad
    https://github.com/scummvm/scummvm/commit/006801dcdda1f6134904161cf6aee49113801bad
Author: Donovan Watteau (contrib at dwatteau.fr)
Date: 2024-08-14T22:00:15+02:00

Commit Message:
CONFIGURE: RISCOS: Avoid -Wformat noise about "GNU extensions" on RISC OS

They're not GNU extensions anymore, and should be part of the C++11
standard, but the older RISC OS (with GCC 4.7) probably gets something
wrong, there.

Changed paths:
    configure


diff --git a/configure b/configure
index fda8b8dd9a0..742b451aba2 100755
--- a/configure
+++ b/configure
@@ -2363,6 +2363,14 @@ if test "$have_gcc" = yes ; then
 	openbsd*)
 		pedantic=no
 		;;
+	riscos)
+		# -Wformat complains about '%z' and so on. Don't know if it's related to
+		# the older compiler not being completely C+11-aware, or something else.
+		if test "$have_gcc" = yes && test $_cxx_major -eq 4 && test $_cxx_minor -le 7; then
+			std_variant=gnu++
+			pedantic=no
+		fi
+		;;
 	*)
 		;;
 	esac