[Scummvm-git-logs] scummvm master -> 120b1310e6aa10353585d815894642fdda4ee34b

AndywinXp noreply at scummvm.org
Mon Aug 19 14:48:05 UTC 2024


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
120b1310e6 SCUMM: INDY3/LOOM (Amiga): Fix volume value overflow


Commit: 120b1310e6aa10353585d815894642fdda4ee34b
    https://github.com/scummvm/scummvm/commit/120b1310e6aa10353585d815894642fdda4ee34b
Author: AndywinXp (andywinxp at gmail.com)
Date: 2024-08-19T16:47:57+02:00

Commit Message:
SCUMM: INDY3/LOOM (Amiga): Fix volume value overflow

This could bring sound volume to 0 whenever the volume parameter
was 256.

This fixes #13278:
"SCUMM: Indiana Jones 3 and Loom Amiga versions - No Sound"

Changed paths:
    engines/scumm/players/player_v3a.cpp


diff --git a/engines/scumm/players/player_v3a.cpp b/engines/scumm/players/player_v3a.cpp
index 75190e36274..0d7a95a25b5 100644
--- a/engines/scumm/players/player_v3a.cpp
+++ b/engines/scumm/players/player_v3a.cpp
@@ -143,7 +143,7 @@ Player_V3A::~Player_V3A() {
 }
 
 void Player_V3A::setMusicVolume (int vol) {
-	_mixer->setChannelVolume(_soundHandle, vol);
+	_mixer->setChannelVolume(_soundHandle, CLIP<int>(vol, 0, 255));
 }
 
 void Player_V3A::stopAllSounds() {




More information about the Scummvm-git-logs mailing list