[Scummvm-git-logs] scummvm master -> 5f6b3bde9784bc040a4c57175f241ae419c0d73b

[dwatteau]

This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
5f6b3bde97 CONFIGURE: Disable -Wno-maybe-uninitialized for GCC 4.8


Commit: 5f6b3bde9784bc040a4c57175f241ae419c0d73b
    https://github.com/scummvm/scummvm/commit/5f6b3bde9784bc040a4c57175f241ae419c0d73b
Author: Donovan Watteau (contrib at dwatteau.fr)
Date: 2024-08-23T13:17:16+02:00

Commit Message:
CONFIGURE: Disable -Wno-maybe-uninitialized for GCC 4.8

I had limited it to GCC 4.8 and newer, but I see in the OSX PPC builds
that GCC 4.8 still has way too many false positives there, compared to
the behavior of newer GCC releases.

Changed paths:
    configure


diff --git a/configure b/configure
index 742b451aba2..ebda4c60ff5 100755
--- a/configure
+++ b/configure
@@ -2286,21 +2286,27 @@ if test "$have_gcc" = yes; then
 	else
 		cxx_version="GCC $cxx_version, ok"
 
-		# Way too many false positives before GCC 5
+		# Some warnings exist in earlier GCC releases, but produce way
+		# too many false positives...
+
 		if test $_cxx_major -ge 5; then
 			append_var CXXFLAGS "-Wshadow"
 		else
 			append_var CXXFLAGS "-Wno-missing-field-initializers"
-		fi
 
-		# Many false positives before GCC 4.8, e.g. with templates
-		if test $_cxx_major -eq 4 && test $_cxx_minor -le 7; then
-			append_var CXXFLAGS "-Wno-type-limits"
-			append_var CXXFLAGS "-Wno-uninitialized"
-			append_var CXXFLAGS "-Wno-maybe-uninitialized"
-			append_var CXXFLAGS "-Wno-array-bounds"
-		fi
+			if test $_cxx_major -eq 4; then
+				# Many false positives with templates
+				if test $_cxx_minor -le 7; then
+					append_var CXXFLAGS "-Wno-type-limits"
+					append_var CXXFLAGS "-Wno-uninitialized"
+					append_var CXXFLAGS "-Wno-array-bounds"
+				fi
 
+				if test $_cxx_minor -le 8; then
+					append_var CXXFLAGS "-Wno-maybe-uninitialized"
+				fi
+			fi
+		fi
 	fi
 elif test "$have_icc" = yes; then
 	cxx_version="`( $CXX -dumpversion ) 2>/dev/null`"