[Scummvm-git-logs] scummvm master -> 916f2dabc7f81057ef6fc84c71754573f501002b

[rvanlaar]

This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
916f2dabc7 DIRECTOR: Error buildbot on end of stream castread


Commit: 916f2dabc7f81057ef6fc84c71754573f501002b
    https://github.com/scummvm/scummvm/commit/916f2dabc7f81057ef6fc84c71754573f501002b
Author: Roland van Laar (roland at rolandvanlaar.nl)
Date: 2024-08-28T15:12:06+02:00

Commit Message:
DIRECTOR: Error buildbot on end of stream castread

The following was found in Director 5 when reading text casts.
The relevant part for the cast is copied from the filestream in a
MemoryReadStreamEndian. `eos` is set when more is read then is available
but it won't error out.
In this case we want a warning when this happens and an error in the
buildbot. It probably means we don't load casts right yet.

Changed paths:
    engines/director/cast.cpp


diff --git a/engines/director/cast.cpp b/engines/director/cast.cpp
index 5d45b86aeba..fcf4b7e14ed 100644
--- a/engines/director/cast.cpp
+++ b/engines/director/cast.cpp
@@ -1095,6 +1095,9 @@ void Cast::loadCastData(Common::SeekableReadStreamEndian &stream, uint16 id, Res
 		castInfoSize = 0;
 		break;
 	}
+	if (castStream.eos()) {
+		warning("BUILDBOT: Read past dataStream for id: %d", id);
+	}
 
 	if (_loadedCast->contains(id)) { // Skip unhandled casts
 		debugCN(3, kDebugLoading, "Children: ");