[Scummvm-git-logs] scummvm master -> 53778fb0fa6e918196b09356f230161986c87613

sluicebox noreply at scummvm.org
Sat Dec 7 16:51:14 UTC 2024


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
53778fb0fa SCI: Fix resource.cfg parsing in fallback detection


Commit: 53778fb0fa6e918196b09356f230161986c87613
    https://github.com/scummvm/scummvm/commit/53778fb0fa6e918196b09356f230161986c87613
Author: sluicebox (22204938+sluicebox at users.noreply.github.com)
Date: 2024-12-07T08:49:37-08:00

Commit Message:
SCI: Fix resource.cfg parsing in fallback detection

Fixes "language" not being read when on last line

Changed paths:
    engines/sci/metaengine.cpp


diff --git a/engines/sci/metaengine.cpp b/engines/sci/metaengine.cpp
index e5770332335..517d694d8ba 100644
--- a/engines/sci/metaengine.cpp
+++ b/engines/sci/metaengine.cpp
@@ -636,11 +636,8 @@ ADDetectedGame SciMetaEngine::fallbackDetectExtern(uint md5Bytes, const FileMap
 	for (int i = 0; i < ARRAYSIZE(configNames) && language == Common::EN_ANY; i++) {
 		Common::File file;
 		if (allFiles.contains(configNames[i]) && file.open(allFiles[configNames[i]])) {
-			while (true) {
+			while (!file.eos()) {
 				Common::String line = file.readLine();
-				if (file.eos()) {
-					break;
-				}
 				uint32 separatorPos = line.find('=');
 				if (separatorPos == Common::String::npos) {
 					continue;




More information about the Scummvm-git-logs mailing list