[Scummvm-git-logs] scummvm branch-2-8 -> 0e36250c291119f4c652ee9543113bcadcaf9dac

[sev-]

This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
0e36250c29 SURFACESDL: Refresh cursor scaler along whith standard scaler (bug #14872)


Commit: 0e36250c291119f4c652ee9543113bcadcaf9dac
    https://github.com/scummvm/scummvm/commit/0e36250c291119f4c652ee9543113bcadcaf9dac
Author: Torbjörn Andersson (eriktorbjorn at users.sourceforge.net)
Date: 2024-02-11T16:35:08+01:00

Commit Message:
SURFACESDL: Refresh cursor scaler along whith standard scaler (bug #14872)

Otherwise, the cursor scaler and standard scaler may be different types,
which can lead to scaling the cursor with a scaler that normally doesn't
allow it. In this particular bug report, it caused ScummVM to crash.

Changed paths:
    backends/graphics/surfacesdl/surfacesdl-graphics.cpp


diff --git a/backends/graphics/surfacesdl/surfacesdl-graphics.cpp b/backends/graphics/surfacesdl/surfacesdl-graphics.cpp
index 6d9d8d062dd..8dcf8799165 100644
--- a/backends/graphics/surfacesdl/surfacesdl-graphics.cpp
+++ b/backends/graphics/surfacesdl/surfacesdl-graphics.cpp
@@ -683,6 +683,11 @@ void SurfaceSdlGraphicsManager::setGraphicsModeIntern() {
 
 		_scalerPlugin = &_scalerPlugins[_videoMode.scalerIndex]->get<ScalerPluginObject>();
 		_scaler = _scalerPlugin->createInstance(format);
+
+		if (_mouseScaler != nullptr) {
+			delete _mouseScaler;
+			_mouseScaler = _scalerPlugin->createInstance(_cursorFormat);
+		}
 	}
 
 	_scaler->setFactor(_videoMode.scaleFactor);