[Scummvm-git-logs] scummvm master -> 3a3f4b824fb7107e0956e955d80702cec6ab321c

[digitall]

This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
3a3f4b824f DIRECTOR: Fix GCC Type Limits Compiler Warning


Commit: 3a3f4b824fb7107e0956e955d80702cec6ab321c
    https://github.com/scummvm/scummvm/commit/3a3f4b824fb7107e0956e955d80702cec6ab321c
Author: D G Turner (digitall at scummvm.org)
Date: 2024-06-24T21:21:48+01:00

Commit Message:
DIRECTOR: Fix GCC Type Limits Compiler Warning

The _filmLoopFrame is defined as unsigned so the negative value check
is redundant and causes a warning if -Wtype-limits is passed to GCC.

Changed paths:
    engines/director/castmember/filmloop.cpp


diff --git a/engines/director/castmember/filmloop.cpp b/engines/director/castmember/filmloop.cpp
index a80a7b74db7..251d3f51d1f 100644
--- a/engines/director/castmember/filmloop.cpp
+++ b/engines/director/castmember/filmloop.cpp
@@ -84,7 +84,7 @@ Common::Array<Channel> *FilmLoopCastMember::getSubChannels(Common::Rect &bbox, C
 
 	_subchannels.clear();
 
-	if (channel->_filmLoopFrame < 0 || channel->_filmLoopFrame >= _frames.size()) {
+	if (channel->_filmLoopFrame >= _frames.size()) {
 		warning("FilmLoopCastMember::getSubChannels(): Film loop frame %d requested, only %d available", channel->_filmLoopFrame, _frames.size());
 		return &_subchannels;
 	}