[Scummvm-git-logs] scummvm master -> 0ec113629abe772cf01b275db6c247b9b290be30

sev- noreply at scummvm.org
Sun Jun 30 18:44:41 UTC 2024


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
0ec113629a GUI: Fix crash in edit game dialog when plugins are unloaded


Commit: 0ec113629abe772cf01b275db6c247b9b290be30
    https://github.com/scummvm/scummvm/commit/0ec113629abe772cf01b275db6c247b9b290be30
Author: Cameron Cawley (ccawley2011 at gmail.com)
Date: 2024-06-30T20:44:38+02:00

Commit Message:
GUI: Fix crash in edit game dialog when plugins are unloaded

Changed paths:
    gui/editgamedialog.cpp


diff --git a/gui/editgamedialog.cpp b/gui/editgamedialog.cpp
index 0b723383474..742b5b2328e 100644
--- a/gui/editgamedialog.cpp
+++ b/gui/editgamedialog.cpp
@@ -476,9 +476,8 @@ void EditGameDialog::close() {
 
 	// Cleanup engine widgets before unloading its plugin
 	if (_engineOptions) {
-		// Switch back to Game tab before deleting the widget
-		_tabWidget->setActiveTab(0);
-		_tabWidget->removeWidget(_engineOptions);
+		// Remove the widget from the container before deleting the widget
+		_gameContainer->removeWidget(_engineOptions);
 		delete _engineOptions;
 	}
 




More information about the Scummvm-git-logs mailing list