[Scummvm-git-logs] scummvm master -> 3dcd3e6fa604893805791dccf0a84af39ca87146

digitall noreply at scummvm.org
Sat Mar 30 16:40:56 UTC 2024


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
3dcd3e6fa6 GRAPHICS: MACGUI: Fix Signed vs. Unsigned Comparison GCC Compiler Warnings


Commit: 3dcd3e6fa604893805791dccf0a84af39ca87146
    https://github.com/scummvm/scummvm/commit/3dcd3e6fa604893805791dccf0a84af39ca87146
Author: D G Turner (digitall at scummvm.org)
Date: 2024-03-30T16:40:22Z

Commit Message:
GRAPHICS: MACGUI: Fix Signed vs. Unsigned Comparison GCC Compiler Warnings

Changed paths:
    graphics/macgui/macmenu.cpp


diff --git a/graphics/macgui/macmenu.cpp b/graphics/macgui/macmenu.cpp
index 471b96022d3..fa1d7eefde9 100644
--- a/graphics/macgui/macmenu.cpp
+++ b/graphics/macgui/macmenu.cpp
@@ -1104,7 +1104,7 @@ void MacMenu::renderSubmenu(MacMenuSubMenu *menu, bool recursive) {
 	int ovTop = menu->visStart + menu->scroll; // Number of items overflowing from top
 	int ovBot = menu->items.size() - ovTop - numVis; // Number of items overflowing from bottom
 
-	for (uint i = menu->visStart + menu->scroll; i < menu->items.size(); i++) {
+	for (int i = menu->visStart + menu->scroll; i < (int)menu->items.size(); i++) {
 		if ((ovTop && i == menu->visStart + menu->scroll) ||
 			(ovBot && i == numVis - 1 + menu->scroll + menu->visStart)) {
 			int direction = (i == menu->visStart + menu->scroll) ? 1 : -1;
@@ -1136,7 +1136,7 @@ void MacMenu::renderSubmenu(MacMenuSubMenu *menu, bool recursive) {
 		}
 
 		int color = _wm->_colorBlack;
-		if (i == (uint)menu->highlight && (!text.empty() || !unicodeText.empty()) && menu->items[i]->enabled) {
+		if (i == menu->highlight && (!text.empty() || !unicodeText.empty()) && menu->items[i]->enabled) {
 			color = _wm->_colorWhite;
 			Common::Rect trect(r->left, y - (_wm->_fontMan->hasBuiltInFonts() ? 1 : 0), r->right, y + _font->getFontHeight());
 




More information about the Scummvm-git-logs mailing list