[Scummvm-git-logs] scummvm master -> 5040e1129dc62356214fe92b606d325f0d3d6919

sev- noreply at scummvm.org
Thu May 30 07:25:15 UTC 2024


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
5040e1129d GRAPHICS: OPENGL: Disable usage of sscanf_s


Commit: 5040e1129dc62356214fe92b606d325f0d3d6919
    https://github.com/scummvm/scummvm/commit/5040e1129dc62356214fe92b606d325f0d3d6919
Author: Eugene Sandulenko (sev at scummvm.org)
Date: 2024-05-30T09:24:59+02:00

Commit Message:
GRAPHICS: OPENGL: Disable usage of sscanf_s

This follows the earlier commit that added this symbol to forbidden.h
The code in glad.h is not using any features of sscanf_s, e.g.
sizes for the provided strings for safety, so it is not clear
why are they using it. Perhaps because it is declared "safer"

Changed paths:
    graphics/opengl/glad.h


diff --git a/graphics/opengl/glad.h b/graphics/opengl/glad.h
index dc801d6bfa0..8c8f4775eda 100644
--- a/graphics/opengl/glad.h
+++ b/graphics/opengl/glad.h
@@ -7750,11 +7750,11 @@ GLAD_API_CALL int gladLoadGLES2( GLADloadfunc load);
 #ifndef GLAD_IMPL_UTIL_C_
 #define GLAD_IMPL_UTIL_C_
 
-#ifdef _MSC_VER
-#define GLAD_IMPL_UTIL_SSCANF sscanf_s
-#else
+//#ifdef _MSC_VER
+//#define GLAD_IMPL_UTIL_SSCANF sscanf_s
+//#else
 #define GLAD_IMPL_UTIL_SSCANF sscanf
-#endif
+//#endif
 
 #endif /* GLAD_IMPL_UTIL_C_ */
 
@@ -13173,7 +13173,7 @@ int gladLoadGLES2( GLADloadfunc load) {
 
 
 
- 
+
 
 
 #ifdef __cplusplus
@@ -13181,4 +13181,3 @@ int gladLoadGLES2( GLADloadfunc load) {
 #endif
 
 #endif /* GLAD_GL_IMPLEMENTATION */
-




More information about the Scummvm-git-logs mailing list