[Scummvm-git-logs] scummvm master -> a3a7fa9601e0ed47e063fe395e0d79aafd849d46

[aquadran]

This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
a3a7fa9601 WINTERMUTE: setting depth range is not needed, not used by engine


Commit: a3a7fa9601e0ed47e063fe395e0d79aafd849d46
    https://github.com/scummvm/scummvm/commit/a3a7fa9601e0ed47e063fe395e0d79aafd849d46
Author: Paweł Kołodziejski (aquadran at gmail.com)
Date: 2024-11-01T16:56:44+01:00

Commit Message:
WINTERMUTE: setting depth range is not needed, not used by engine

Changed paths:
    engines/wintermute/base/gfx/opengl/base_render_opengl3d.cpp
    engines/wintermute/base/gfx/opengl/base_render_opengl3d_shader.cpp


diff --git a/engines/wintermute/base/gfx/opengl/base_render_opengl3d.cpp b/engines/wintermute/base/gfx/opengl/base_render_opengl3d.cpp
index b890aef2f5e..4bc4c751490 100644
--- a/engines/wintermute/base/gfx/opengl/base_render_opengl3d.cpp
+++ b/engines/wintermute/base/gfx/opengl/base_render_opengl3d.cpp
@@ -906,25 +906,21 @@ void BaseRenderOpenGL3D::disableCulling() {
 	glDisable(GL_CULL_FACE);
 }
 
-// implements D3D SetViewport() for 2D viewport
+// implements D3D SetViewport() for 2D renderer
 bool BaseRenderOpenGL3D::setViewport(int left, int top, int right, int bottom) {
 	_viewportRect.setRect(left, top, right, bottom);
 	_viewport._x = left;
 	_viewport._y = top;
 	_viewport._width = right - left;
 	_viewport._height = bottom - top;
-	_viewport._minZ = 0.0f;
-	_viewport._maxZ = 1.0f;
 	glViewport(left, _height - bottom, right - left, bottom - top);
-	glDepthRange(_viewport._minZ, _viewport._maxZ);
 	return true;
 }
 
-// implements D3D SetViewport() for 3D viewport
+// implements D3D SetViewport() for 3D renderer
 bool BaseRenderOpenGL3D::setViewport3D(DXViewport *viewport) {
 	_viewport = *viewport;
 	glViewport(_viewport._x, _height - _viewport._height, _viewport._width, _viewport._height);
-	glDepthRange(_viewport._minZ, _viewport._maxZ);
 	return true;
 }
 
diff --git a/engines/wintermute/base/gfx/opengl/base_render_opengl3d_shader.cpp b/engines/wintermute/base/gfx/opengl/base_render_opengl3d_shader.cpp
index 97c59c48272..52c8111860a 100644
--- a/engines/wintermute/base/gfx/opengl/base_render_opengl3d_shader.cpp
+++ b/engines/wintermute/base/gfx/opengl/base_render_opengl3d_shader.cpp
@@ -744,25 +744,21 @@ void BaseRenderOpenGL3DShader::disableCulling() {
 	glDisable(GL_CULL_FACE);
 }
 
-// implements D3D SetViewport() for 2D viewport
+// implements D3D SetViewport() for 2D renderer
 bool BaseRenderOpenGL3DShader::setViewport(int left, int top, int right, int bottom) {
 	_viewportRect.setRect(left, top, right, bottom);
 	_viewport._x = left;
 	_viewport._y = top;
 	_viewport._width = right - left;
 	_viewport._height = bottom - top;
-	_viewport._minZ = 0.0f;
-	_viewport._maxZ = 1.0f;
 	glViewport(left, _height - bottom, right - left, bottom - top);
-	glDepthRange(_viewport._minZ, _viewport._maxZ);
 	return true;
 }
 
-// implements D3D SetViewport() for 3D viewport
+// implements D3D SetViewport() for 3D renderer
 bool BaseRenderOpenGL3DShader::setViewport3D(DXViewport *viewport) {
 	_viewport = *viewport;
 	glViewport(_viewport._x, _height - _viewport._height, _viewport._width, _viewport._height);
-	glDepthRange(_viewport._minZ, _viewport._maxZ);
 	return true;
 }