[Scummvm-git-logs] scummvm master -> b68d93cae5b58a53b951b6f73629c5eb1e8c9179

[lephilousophe]

This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
b68d93cae5 CLOUD: Move saves synchronization to file destruction


Commit: b68d93cae5b58a53b951b6f73629c5eb1e8c9179
    https://github.com/scummvm/scummvm/commit/b68d93cae5b58a53b951b6f73629c5eb1e8c9179
Author: Le Philousophe (lephilousophe at users.noreply.github.com)
Date: 2024-11-15T16:31:48+01:00

Commit Message:
CLOUD: Move saves synchronization to file destruction

The finalize call is a no-op and syncing saves at this point is too early as
the save file is not materialized on disk yet when written atomically.

Changed paths:
    backends/saves/savefile.cpp


diff --git a/backends/saves/savefile.cpp b/backends/saves/savefile.cpp
index bba0aea55f9..a2ae858d056 100644
--- a/backends/saves/savefile.cpp
+++ b/backends/saves/savefile.cpp
@@ -32,6 +32,9 @@ OutSaveFile::OutSaveFile(WriteStream *w): _wrapped(w) {}
 
 OutSaveFile::~OutSaveFile() {
 	delete _wrapped;
+#if defined(USE_CLOUD) && defined(USE_LIBCURL)
+	CloudMan.syncSaves();
+#endif
 }
 
 bool OutSaveFile::err() const { return _wrapped->err(); }
@@ -40,9 +43,6 @@ void OutSaveFile::clearErr() { _wrapped->clearErr(); }
 
 void OutSaveFile::finalize() {
 	_wrapped->finalize();
-#if defined(USE_CLOUD) && defined(USE_LIBCURL)
-	CloudMan.syncSaves();
-#endif
 }
 
 bool OutSaveFile::flush() { return _wrapped->flush(); }