[Scummvm-git-logs] scummvm master -> 24e7b4d2c031d07e484dff213206d62bccbe8055

[bluegr]

This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
24e7b4d2c0 SAGA: Remove outdated comment, related to Adlib instrument files


Commit: 24e7b4d2c031d07e484dff213206d62bccbe8055
    https://github.com/scummvm/scummvm/commit/24e7b4d2c031d07e484dff213206d62bccbe8055
Author: Filippos Karapetis (bluegr at gmail.com)
Date: 2024-11-17T02:01:54+02:00

Commit Message:
SAGA: Remove outdated comment, related to Adlib instrument files

When that comment was written, there wasn't any support for the
instrument definition files of the Miles Sound System used with IHNM

Changed paths:
    engines/saga/music.cpp


diff --git a/engines/saga/music.cpp b/engines/saga/music.cpp
index 1f2ca1e386e..c6b28206a56 100644
--- a/engines/saga/music.cpp
+++ b/engines/saga/music.cpp
@@ -150,31 +150,6 @@ Music::Music(SagaEngine *vm, Audio::Mixer *mixer) : _vm(vm), _mixer(mixer), _par
 		if (_vm->getGameId() == GID_ITE) {
 			_musicContext = _vm->_resource->getContext(GAME_RESOURCEFILE);
 		} else if (_vm->getGameId() == GID_IHNM) {
-			// I've listened to music from both the FM and the GM
-			// file, and I've tentatively reached the conclusion
-			// that they are both General MIDI. My guess is that
-			// the FM file has been reorchestrated to sound better
-			// on AdLib and other FM synths.
-			//
-			// Sev says the AdLib music does not sound like in the
-			// original, but I still think assuming General MIDI is
-			// the right thing to do. Some music, like the End
-			// Title (song 0) sound absolutely atrocious when piped
-			// through our MT-32 to GM mapping.
-			//
-			// It is, however, quite possible that the original
-			// used a different GM to FM mapping. If the original
-			// sounded markedly better, perhaps we should add some
-			// way of replacing our stock mapping in adlib.cpp?
-			//
-			// For the composer's own recording of the End Title,
-			// see http://www.johnottman.com/
-
-			// Oddly enough, the intro music (song 1) is very
-			// different in the two files. I have no idea why.
-			// Note that the IHNM demo has only got one music file
-			// (music.rsc). It is assumed that it contains FM music
-
 			// TODO If program flow gets here, this getContext call previously
 			// returned null...
 			_musicContext = _vm->_resource->getContext(GAME_MUSICFILE_FM);