[Scummvm-git-logs] scummvm branch-2-9 -> d3f79b868065d38d49dd66cfa1c35b005d242f49

bluegr noreply at scummvm.org
Thu Nov 21 17:50:47 UTC 2024


This automated email contains information about 2 new commits which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
dba399b215 SCUMM: Fix crash adding the Mac Steam version of Loom
d3f79b8680 SCUMM: Fix MI1 Mac cursor when loading certain saved games - bug #15520


Commit: dba399b215d638a7dcf7faa14847035e999c9e03
    https://github.com/scummvm/scummvm/commit/dba399b215d638a7dcf7faa14847035e999c9e03
Author: Filippos Karapetis (bluegr at gmail.com)
Date: 2024-11-21T19:50:32+02:00

Commit Message:
SCUMM: Fix crash adding the Mac Steam version of Loom

Changed paths:
    engines/scumm/metaengine.cpp


diff --git a/engines/scumm/metaengine.cpp b/engines/scumm/metaengine.cpp
index 86ddbea0e8d..fa354c6849a 100644
--- a/engines/scumm/metaengine.cpp
+++ b/engines/scumm/metaengine.cpp
@@ -601,8 +601,10 @@ GUI::OptionsContainerWidget *ScummMetaEngine::buildLoomOptionsWidget(GUI::GuiObj
 	if (extra == "VGA")
 		return new Scumm::LoomVgaGameOptionsWidget(boss, name, target);
 
-	if (extra == "Steam")
+	if (extra == "Steam" && platform != Common::kPlatformMacintosh)
 		return MetaEngine::buildEngineOptionsWidget(boss, name, target);
+	else if (extra == "Steam" && platform == Common::kPlatformMacintosh)
+		return nullptr;
 	else if (platform == Common::kPlatformMacintosh)
 		return new Scumm::LoomMonkeyMacGameOptionsWidget(boss, name, target, GID_LOOM);
 


Commit: d3f79b868065d38d49dd66cfa1c35b005d242f49
    https://github.com/scummvm/scummvm/commit/d3f79b868065d38d49dd66cfa1c35b005d242f49
Author: Filippos Karapetis (bluegr at gmail.com)
Date: 2024-11-21T19:50:33+02:00

Commit Message:
SCUMM: Fix MI1 Mac cursor when loading certain saved games - bug #15520

We need to reset Mac cursors if the original GUI isn't enabled for games
which replace cursors that override the default cursor palette.

Changed paths:
    engines/scumm/saveload.cpp


diff --git a/engines/scumm/saveload.cpp b/engines/scumm/saveload.cpp
index 11cc8afd51d..6f3281c38c0 100644
--- a/engines/scumm/saveload.cpp
+++ b/engines/scumm/saveload.cpp
@@ -2161,6 +2161,12 @@ void ScummEngine_v5::saveLoadWithSerializer(Common::Serializer &s) {
 		if ((_game.id == GID_LOOM && !_macCursorFile.empty()) || _macGui) {
 			setBuiltinCursor(0);
 		}
+
+		// Also reset Mac cursors if the original GUI isn't enabled for games
+		// which replace cursors that override the default cursor palette - bug #15520.
+		if (_game.id == GID_MONKEY && !_macGui) {
+			setBuiltinCursor(0);
+		}
 	}
 
 	// Regenerate 16bit palette after loading.




More information about the Scummvm-git-logs mailing list