[Scummvm-git-logs] scummvm branch-2-9 -> ea569a624f700db0bcc956212e6f7483009c2c04

[sluicebox]

This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
ea569a624f Revert "SLUDGE: Plug memory leak. CID 1383944"


Commit: ea569a624f700db0bcc956212e6f7483009c2c04
    https://github.com/scummvm/scummvm/commit/ea569a624f700db0bcc956212e6f7483009c2c04
Author: sluicebox (22204938+sluicebox at users.noreply.github.com)
Date: 2024-11-28T11:47:39-08:00

Commit Message:
Revert "SLUDGE: Plug memory leak. CID 1383944"

This reverts commit c383b98f29f0685a6411e990ee660abe13c5cb0c.

Created use-after-free bugs. Several functions use speech
immediately after calling kill.

CID 1564707
CID 1564706
CID 1564705

Changed paths:
    engines/sludge/speech.cpp


diff --git a/engines/sludge/speech.cpp b/engines/sludge/speech.cpp
index 8b2b8b90ae3..0a66f9a31bf 100644
--- a/engines/sludge/speech.cpp
+++ b/engines/sludge/speech.cpp
@@ -68,7 +68,6 @@ void SpeechManager::kill() {
 		killMe = nullptr;
 	}
 	_speech->allSpeech.clear();
-	delete _speech;
 }
 
 void SpeechManager::setObjFontColour(ObjectType *t) {