[Scummvm-git-logs] scummvm master -> fa0cd1d591c01b82475ed0b445578b3edc33f539

yuv422 noreply at scummvm.org
Mon Oct 14 21:45:15 UTC 2024


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
fa0cd1d591 DARKSEED: Add missing constructors PVS-Studio V730


Commit: fa0cd1d591c01b82475ed0b445578b3edc33f539
    https://github.com/scummvm/scummvm/commit/fa0cd1d591c01b82475ed0b445578b3edc33f539
Author: Eric Fry (yuv422 at reversedgames.com)
Date: 2024-10-15T08:45:03+11:00

Commit Message:
DARKSEED: Add missing constructors PVS-Studio V730

Changed paths:
    engines/darkseed/cutscene.h
    engines/darkseed/pic.h


diff --git a/engines/darkseed/cutscene.h b/engines/darkseed/cutscene.h
index 469a16b019b..02aa9e2d35f 100644
--- a/engines/darkseed/cutscene.h
+++ b/engines/darkseed/cutscene.h
@@ -33,19 +33,20 @@ namespace Darkseed {
 
 class Cutscene {
 private:
-	char _cutsceneId;
+	char _cutsceneId = 0;
 	uint16 _movieStep = 9999;
 	TitleFont *_titleFont = nullptr;
 	Pal _palette;
 	Anm _animation;
-	int _animIdx;
-	int _animCount;
-	int _animDelayCount;
-	int _animDirection;
+	int _animIdx = 0;
+	int _animCount = 0;
+	int _animDelayCount = 0;
+	int _animDirection = 0;
 	uint32 _startTime = 0;
 	Morph *_morph = nullptr;
 
 public:
+	Cutscene() {}
 	virtual ~Cutscene();
 	void play(char cutsceneId);
 	bool isPlaying() {
diff --git a/engines/darkseed/pic.h b/engines/darkseed/pic.h
index 34923c9c868..aa2209757bc 100644
--- a/engines/darkseed/pic.h
+++ b/engines/darkseed/pic.h
@@ -30,14 +30,15 @@ namespace Darkseed {
 
 class Pic {
 private:
-	uint16 _width;
-	uint16 _height;
+	uint16 _width = 0;
+	uint16 _height = 0;
 	Common::Array<uint8> _pixels;
 
 	bool _hasReadByte = false;
 	byte _currentDataByte = 0;
 
 public:
+	Pic() {}
 	bool load(const Common::Path &filename);
 	Common::Array<uint8> &getPixels() {
 		return _pixels;




More information about the Scummvm-git-logs mailing list