[Scummvm-git-logs] scummvm master -> f11ec00e1d87600fd3807354eb5472c2e3425556

aquadran noreply at scummvm.org
Thu Oct 24 11:00:12 UTC 2024


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
f11ec00e1d WINTERMUTE: Added TODOs for reimplement shadows for shader renderer


Commit: f11ec00e1d87600fd3807354eb5472c2e3425556
    https://github.com/scummvm/scummvm/commit/f11ec00e1d87600fd3807354eb5472c2e3425556
Author: Paweł Kołodziejski (aquadran at gmail.com)
Date: 2024-10-24T13:00:07+02:00

Commit Message:
WINTERMUTE: Added TODOs for reimplement shadows for shader renderer

Changed paths:
    engines/wintermute/base/gfx/opengl/base_render_opengl3d_shader.cpp


diff --git a/engines/wintermute/base/gfx/opengl/base_render_opengl3d_shader.cpp b/engines/wintermute/base/gfx/opengl/base_render_opengl3d_shader.cpp
index 7f848880e6b..b5d17f0fddf 100644
--- a/engines/wintermute/base/gfx/opengl/base_render_opengl3d_shader.cpp
+++ b/engines/wintermute/base/gfx/opengl/base_render_opengl3d_shader.cpp
@@ -178,7 +178,7 @@ void BaseRenderOpenGL3DShader::disableCulling() {
 }
 
 bool BaseRenderOpenGL3DShader::enableShadows() {
-	return true; // shadows are broken for a while since it use not allowed binding to frame buffer
+	return true; // TODO: reimplement. Shadows are broken for a while since it use not allowed binding to frame buffer
 	if (_flatShadowMaskShader == nullptr) {
 		_flatShadowColor = Math::Vector4d(0.0f, 0.0f, 0.0f, 0.5f);
 
@@ -261,7 +261,7 @@ bool BaseRenderOpenGL3DShader::disableShadows() {
 }
 
 void BaseRenderOpenGL3DShader::displayShadow(BaseObject *object, const DXVector3 *lightPos, bool lightPosRelative) {
-	return; // shadows are broken for a while since it use not allowed binding to frame buffer
+	return; // TODO: reimplement. Shadows are broken for a while since it use not allowed binding to frame buffer
 	if (_flatShadowMaskShader) {
 		if (object->_shadowType <= SHADOW_SIMPLE) {
 			// TODO: Display simple shadow here




More information about the Scummvm-git-logs mailing list