[Scummvm-git-logs] scummvm master -> b735819b960c6fce2e9eab03001c1b36d667713b

[mduggan]

This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
b735819b96 DGDS: Don't draw dialog backgrounds before running scripts


Commit: b735819b960c6fce2e9eab03001c1b36d667713b
    https://github.com/scummvm/scummvm/commit/b735819b960c6fce2e9eab03001c1b36d667713b
Author: Matthew Duggan (mgithub at guarana.org)
Date: 2024-10-27T08:54:47+11:00

Commit Message:
DGDS: Don't draw dialog backgrounds before running scripts

Although the original calls something about dialog backgrounds here, if we
draw the background it causes graphical glitches.

There are still some imperfect drawing related to dialogs (eg, Karyn's
background sometimes disappears while talking to her) but this cleans up the
most obvious problems.

Changed paths:
    engines/dgds/dgds.cpp


diff --git a/engines/dgds/dgds.cpp b/engines/dgds/dgds.cpp
index eacc557a212..86f29035f00 100644
--- a/engines/dgds/dgds.cpp
+++ b/engines/dgds/dgds.cpp
@@ -608,7 +608,14 @@ Common::Error DgdsEngine::run() {
 
 			_compositionBuffer.transBlitFrom(_storedAreaBuffer);
 
-			_scene->drawActiveDialogBgs(&_compositionBuffer);
+			//
+			// The originals do something about drawing the background of dialogs here
+			// but that causes graphical glitches in scenes when a region is saved as it
+			// saves the dialog background too (eg, dragon scene 79).
+			//
+			// Instead we just draw the background and foreground of dialogs at the end.
+			//
+			//_scene->drawActiveDialogBgs(&_compositionBuffer);
 
 			if (_scene->getNum() != 2 || _inventory->isZoomVisible())
 				_adsInterp->run();