[Scummvm-git-logs] scummvm master -> 84c4e14faff6f17a437ebb595a34d0cd14a8a78c

mduggan noreply at scummvm.org
Wed Oct 30 06:13:00 UTC 2024


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
84c4e14faf DGDS: Make virtual targets explicit in constructor/destructor. PVS-Studio V1053


Commit: 84c4e14faff6f17a437ebb595a34d0cd14a8a78c
    https://github.com/scummvm/scummvm/commit/84c4e14faff6f17a437ebb595a34d0cd14a8a78c
Author: Matthew Duggan (mgithub at guarana.org)
Date: 2024-10-30T17:11:47+11:00

Commit Message:
DGDS: Make virtual targets explicit in constructor/destructor. PVS-Studio V1053

Changed paths:
    engines/dgds/sound/midiparser_sci.cpp


diff --git a/engines/dgds/sound/midiparser_sci.cpp b/engines/dgds/sound/midiparser_sci.cpp
index a422ea501ec..b0ea074a596 100644
--- a/engines/dgds/sound/midiparser_sci.cpp
+++ b/engines/dgds/sound/midiparser_sci.cpp
@@ -45,7 +45,7 @@ MidiParser_SCI::MidiParser_SCI(SciMusic *music) :
 	// mididata contains delta in 1/60th second
 	// values of ppqn and tempo are found experimentally and may be wrong
 	_ppqn = 1;
-	setTempo(16667);
+	MidiParser::setTempo(16667);
 
 	_track = nullptr;
 	_pSnd = nullptr;
@@ -61,7 +61,7 @@ MidiParser_SCI::MidiParser_SCI(SciMusic *music) :
 }
 
 MidiParser_SCI::~MidiParser_SCI() {
-	unloadMusic();
+	MidiParser_SCI::unloadMusic();
 	// we do this, so that MidiParser won't be able to call his own ::allNotesOff()
 	//  this one would affect all channels and we can't let that happen
 	_driver = nullptr;




More information about the Scummvm-git-logs mailing list