[Scummvm-git-logs] scummvm master -> 398fb6d232bbb395de015d572ceefcda8fade4b9

[dwatteau]

This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
398fb6d232 SCUMM: MONKEY2: Document the behavior of the 'pulling the rope' bug in the Special Edition


Commit: 398fb6d232bbb395de015d572ceefcda8fade4b9
    https://github.com/scummvm/scummvm/commit/398fb6d232bbb395de015d572ceefcda8fade4b9
Author: Donovan Watteau (contrib at dwatteau.fr)
Date: 2024-10-30T22:14:45+01:00

Commit Message:
SCUMM: MONKEY2: Document the behavior of the 'pulling the rope' bug in the Special Edition

It appears that the Special Edition is based on the original English
release, and so it contains the buggy script for the rope on Dinky Island.
But it doesn't cause a fatal error there, and "just" causes various funny
visual glitches, when playing in Classic Mode.

Documenting it near the workaround we have for this.

Changed paths:
    engines/scumm/script.cpp


diff --git a/engines/scumm/script.cpp b/engines/scumm/script.cpp
index 66ef0c3c3d8..c41a0a713ed 100644
--- a/engines/scumm/script.cpp
+++ b/engines/scumm/script.cpp
@@ -182,6 +182,10 @@ int ScummEngine::getVerbEntrypoint(int obj, int entry) {
 	// release completely disables pulling the rope, instead. We
 	// choose to follow the latter, as it's simpler, and the former
 	// made Guybrush silent when trying to trigger this action.
+	//
+	// (The Special Edition is based on the original release with
+	// the buggy script, but it doesn't cause any fatal error,
+	// although it does glitch, when playing in Classic Mode.)
 	if (_game.id == GID_MONKEY2 && obj == 1047 && entry == 6 && whereIsObject(obj) == WIO_INVENTORY &&
 		enhancementEnabled(kEnhGameBreakingBugFixes)) {
 		return 0;