[Scummvm-git-logs] scummvm master -> 79b32fae61fdf4c9a346758d729e8fb8fdca4281

AndywinXp noreply at scummvm.org
Mon Sep 16 20:17:24 UTC 2024


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
79b32fae61 SCUMM: BASKETBALL: Fix collision values reading from file


Commit: 79b32fae61fdf4c9a346758d729e8fb8fdca4281
    https://github.com/scummvm/scummvm/commit/79b32fae61fdf4c9a346758d729e8fb8fdca4281
Author: AndywinXp (andywinxp at gmail.com)
Date: 2024-09-16T22:17:19+02:00

Commit Message:
SCUMM: BASKETBALL: Fix collision values reading from file

This fixes the nasty bug from hell where the ball disappeared,
a.k.a.: it bounced back from a collision shape with a velocity vector
of about one billion units per component.

Changed paths:
    engines/scumm/he/basketball/collision/bball_collision.cpp


diff --git a/engines/scumm/he/basketball/collision/bball_collision.cpp b/engines/scumm/he/basketball/collision/bball_collision.cpp
index 09c6958384b..ead3381d1eb 100644
--- a/engines/scumm/he/basketball/collision/bball_collision.cpp
+++ b/engines/scumm/he/basketball/collision/bball_collision.cpp
@@ -106,8 +106,8 @@ int LogicHEBasketball::u32_userInitCourt(int courtID) {
 
 		// Read in all other object attributes...
 		currentObject->_objectType = (EObjectType)objectFile.readUint32LE();
-		currentObject->_collisionEfficiency = objectFile.readUint32LE();
-		currentObject->_friction  = objectFile.readUint32LE();
+		currentObject->_collisionEfficiency = objectFile.readFloatLE();
+		currentObject->_friction  = objectFile.readFloatLE();
 		currentObject->_soundNumber = objectFile.readUint32LE();
 		currentObject->_objectID = objectFile.readUint32LE();
 		currentObject->minPoint.x = objectFile.readUint32LE();




More information about the Scummvm-git-logs mailing list