[Scummvm-git-logs] scummvm master -> 4259a3ed4f11e844e05e3a101d668002317290bc

mduggan noreply at scummvm.org
Mon Sep 23 03:17:59 UTC 2024


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
4259a3ed4f DGDS: Remove pointless comparison to fix warning


Commit: 4259a3ed4f11e844e05e3a101d668002317290bc
    https://github.com/scummvm/scummvm/commit/4259a3ed4f11e844e05e3a101d668002317290bc
Author: Matthew Duggan (mgithub at guarana.org)
Date: 2024-09-23T13:17:52+10:00

Commit Message:
DGDS: Remove pointless comparison to fix warning

Changed paths:
    engines/dgds/dragon_arcade_ttm.cpp


diff --git a/engines/dgds/dragon_arcade_ttm.cpp b/engines/dgds/dragon_arcade_ttm.cpp
index 123fc329468..e5dc44b4a71 100644
--- a/engines/dgds/dragon_arcade_ttm.cpp
+++ b/engines/dgds/dragon_arcade_ttm.cpp
@@ -329,9 +329,11 @@ void DragonArcadeTTM::runPagesForEachNPC(int16 xScrollOffset) {
 			_drawXOffset = npcState.xx - xScrollOffset * 8 - 152;
 			_drawYOffset = npcState.yy;
 			_currentTTMNum = npcState.ttmNum;
-			if (_drawXOffset > -20 || _drawXOffset < 340) {
-				runNextPage(npcState.ttmPage);
-			}
+
+			// The original does this comparison, but it seems like a bug (should be &&)
+			// We could correct the check, but better to maintain bug compatibility.
+			// if (_drawXOffset > -20 || _drawXOffset < 340)
+			runNextPage(npcState.ttmPage);
 		}
 	}
 }




More information about the Scummvm-git-logs mailing list