[Scummvm-git-logs] scummvm master -> d64bd43e774cd52c68bd5a520520eaa235c63f6f

sluicebox noreply at scummvm.org
Tue Sep 24 06:20:27 UTC 2024


This automated email contains information about 2 new commits which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
90c5822911 QDENGINE: Fix malloc/delete mismatch. PVS-Studio V611
d64bd43e77 QDENGINE: Fix memory leaks. PVS-Studio V773


Commit: 90c5822911fd8c612680d576cc8e4c64b72cb6bd
    https://github.com/scummvm/scummvm/commit/90c5822911fd8c612680d576cc8e4c64b72cb6bd
Author: sluicebox (22204938+sluicebox at users.noreply.github.com)
Date: 2024-09-23T23:00:34-07:00

Commit Message:
QDENGINE: Fix malloc/delete mismatch. PVS-Studio V611

Changed paths:
    engines/qdengine/minigames/tetris.h


diff --git a/engines/qdengine/minigames/tetris.h b/engines/qdengine/minigames/tetris.h
index b191be0d3cb..abfc2a13e42 100644
--- a/engines/qdengine/minigames/tetris.h
+++ b/engines/qdengine/minigames/tetris.h
@@ -35,8 +35,8 @@ public:
 		_flyingObjs = _hiddenObjs = nullptr;
 	}
 	~qdTetrisMiniGame() {
-		delete _flyingObjs;
-		delete _hiddenObjs;
+		free(_flyingObjs);
+		free(_hiddenObjs);
 	}
 
 	bool init(const qdEngineInterface *engine_interface) {


Commit: d64bd43e774cd52c68bd5a520520eaa235c63f6f
    https://github.com/scummvm/scummvm/commit/d64bd43e774cd52c68bd5a520520eaa235c63f6f
Author: sluicebox (22204938+sluicebox at users.noreply.github.com)
Date: 2024-09-23T23:18:13-07:00

Commit Message:
QDENGINE: Fix memory leaks. PVS-Studio V773

Changed paths:
    engines/qdengine/debugger/debugtools.cpp


diff --git a/engines/qdengine/debugger/debugtools.cpp b/engines/qdengine/debugger/debugtools.cpp
index bd301185cc7..1b239958397 100644
--- a/engines/qdengine/debugger/debugtools.cpp
+++ b/engines/qdengine/debugger/debugtools.cpp
@@ -125,6 +125,7 @@ ImGuiImage getImageID(Common::Path filename, int frameNum) {
 			animation->redraw(sx / 2, sy / 2, 0, 0.91670f, 0);
 			grDispatcher::instance()->resetSurfaceOverride();
 		}
+		delete animation;
 	} else if (_state->_displayMode == kDisplayTGA) {
 		qdSprite *sprite = new qdSprite();
 		if (sprite->load(filename)) {
@@ -139,6 +140,7 @@ ImGuiImage getImageID(Common::Path filename, int frameNum) {
 		} else {
 			warning("Error loading TGA file '%s'", transCyrillic(filename.toString()));
 		}
+		delete sprite;
 	}
 
 	if (surface)




More information about the Scummvm-git-logs mailing list