[Scummvm-git-logs] scummvm master -> e264dc4e2226eb912da6b05c2d213b0208aefddc

AndywinXp noreply at scummvm.org
Sat Sep 28 21:08:45 UTC 2024


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
e264dc4e22 SCUMM: Fix uninit use of _generateRandomMaps


Commit: e264dc4e2226eb912da6b05c2d213b0208aefddc
    https://github.com/scummvm/scummvm/commit/e264dc4e2226eb912da6b05c2d213b0208aefddc
Author: AndywinXp (andywinxp at gmail.com)
Date: 2024-09-28T23:08:38+02:00

Commit Message:
SCUMM: Fix uninit use of _generateRandomMaps

Fixes a GUI crash when trying to add Backyard Football 2002,
or try to access its game options.

Changed paths:
    engines/scumm/dialogs.cpp


diff --git a/engines/scumm/dialogs.cpp b/engines/scumm/dialogs.cpp
index a034f30dc1b..681f7a386f4 100644
--- a/engines/scumm/dialogs.cpp
+++ b/engines/scumm/dialogs.cpp
@@ -1767,9 +1767,11 @@ void HENetworkGameOptionsWidget::load() {
 		_sessionServerAddr->setEditString(sessionServerAddr);
 		_sessionServerAddr->setEnabled(enableSessionServer);
 
-		if (ConfMan.hasKey("generate_random_maps", _domain))
-			generateRandomMaps = ConfMan.getBool("generate_random_maps", _domain);
-		_generateRandomMaps->setState(generateRandomMaps);
+		if (_gameid == "moonbase") {
+			if (ConfMan.hasKey("generate_random_maps", _domain))
+				generateRandomMaps = ConfMan.getBool("generate_random_maps", _domain);
+			_generateRandomMaps->setState(generateRandomMaps);
+		}
 	}
 }
 




More information about the Scummvm-git-logs mailing list