[Scummvm-git-logs] scummvm master -> 6b2e03576c1668d3fd4de26080e2d49b44768b14

[bluegr]

This automated email contains information about 2 new commits which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
9517e680be STARK: Support hebrew text
6b2e03576c STARK: Add detection entry for hebrew fan translation


Commit: 9517e680bec839a3b41e3ae2c0d568e3371f7a36
    https://github.com/scummvm/scummvm/commit/9517e680bec839a3b41e3ae2c0d568e3371f7a36
Author: BLooperZ (blooperz at users.noreply.github.com)
Date: 2025-04-06T11:36:11+03:00

Commit Message:
STARK: Support hebrew text

Changed paths:
    engines/stark/services/settings.cpp
    engines/stark/ui/world/dialogpanel.cpp
    engines/stark/visual/text.cpp


diff --git a/engines/stark/services/settings.cpp b/engines/stark/services/settings.cpp
index ec75f7193d8..bd533bf6f58 100644
--- a/engines/stark/services/settings.cpp
+++ b/engines/stark/services/settings.cpp
@@ -108,6 +108,8 @@ Common::CodePage Settings::getTextCodePage() const {
 		return Common::kWindows1250;
 	case Common::RU_RUS:
 		return Common::kWindows1251;
+	case Common::HE_ISR:
+		return Common::kWindows1255;
 	default:
 		return Common::kWindows1252;
 	}
diff --git a/engines/stark/ui/world/dialogpanel.cpp b/engines/stark/ui/world/dialogpanel.cpp
index bdb804502a8..d17bbb63e3b 100644
--- a/engines/stark/ui/world/dialogpanel.cpp
+++ b/engines/stark/ui/world/dialogpanel.cpp
@@ -165,6 +165,7 @@ void DialogPanel::updateSubtitleVisual() {
 
 	_subtitleVisual = new VisualText(_gfx);
 	_subtitleVisual->setText(_currentSpeech->getPhrase());
+	_subtitleVisual->setAlign(Graphics::TextAlign::kTextAlignStart);
 	_subtitleVisual->setColor(color);
 	_subtitleVisual->setFont(FontProvider::kBigFont);
 	_subtitleVisual->setTargetWidth(600);
diff --git a/engines/stark/visual/text.cpp b/engines/stark/visual/text.cpp
index 54dd2498884..384940b1e23 100644
--- a/engines/stark/visual/text.cpp
+++ b/engines/stark/visual/text.cpp
@@ -34,6 +34,7 @@
 #include "engines/stark/services/settings.h"
 
 #include "common/util.h"
+#include "common/unicode-bidi.h"
 
 namespace Stark {
 
@@ -261,6 +262,7 @@ void VisualText::createBitmap() {
 
 	// Make sure lines have approximately consistent height regardless of the characters they use
 	scaledRect.bottom = MAX<int16>(scaledRect.bottom, scaledLineHeight * lines.size());
+	scaledRect.right = MAX<int16>(scaledRect.right, maxScaledLineWidth);
 
 	if (!isBlank()) {
 		_originalRect.right = StarkGfx->scaleWidthCurrentToOriginal(scaledRect.right);
@@ -281,9 +283,12 @@ void VisualText::createBitmap() {
 
 	surface.fillRect(Common::Rect(surface.w, surface.h), black);
 
+	Graphics::TextAlign align = Graphics::convertTextAlignH(_align, StarkSettings->getLanguage() == Common::HE_ISR);
+
 	// Render the lines to the surface
 	for (uint i = 0; i < lines.size(); i++) {
-		font->drawString(&surface, lines[i], 0, scaledLineHeight * i, surface.w, white, _align, 0, false);
+		Common::U32String line = convertBiDiU32String(lines[i]).visual;
+		font->drawString(&surface, line, 0, scaledLineHeight * i, surface.w, white, align, 0, false);
 	}
 
 	// Blend the text color with the alpha mask to produce an image of the text


Commit: 6b2e03576c1668d3fd4de26080e2d49b44768b14
    https://github.com/scummvm/scummvm/commit/6b2e03576c1668d3fd4de26080e2d49b44768b14
Author: BLooperZ (blooperz at users.noreply.github.com)
Date: 2025-04-06T11:36:11+03:00

Commit Message:
STARK: Add detection entry for hebrew fan translation

Changed paths:
    engines/stark/detection.cpp


diff --git a/engines/stark/detection.cpp b/engines/stark/detection.cpp
index f8b8fbd8187..3f21def802d 100644
--- a/engines/stark/detection.cpp
+++ b/engines/stark/detection.cpp
@@ -398,6 +398,18 @@ static const ADGameDescription gameDescriptions[] = {
 		GUIO_NONE
 	},
 
+	// The Longest Journey
+	// Hebrew fan-made
+	{
+		"tlj", "Fanmade",
+		AD_ENTRY2s("x.xarc",		"a0559457126caadab0cadac02d35f26f", 3032,
+				   "chapters.ini",	"53c9b6087044be0ba05f8d7b39c8ae48", 367),
+		Common::HE_ISR,
+		Common::kPlatformWindows,
+		ADGF_NO_FLAGS,
+		GUIO_NONE
+	},
+
 	AD_TABLE_END_MARKER
 };