[Scummvm-git-logs] scummvm master -> 597316ff752a978a8b00da17a731a062c0ea38d8

elasota noreply at scummvm.org
Fri Apr 18 15:20:03 UTC 2025


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://api.github.com/repos/scummvm/scummvm .

Summary:
597316ff75 VIDEO: Fix uninitialized memory access


Commit: 597316ff752a978a8b00da17a731a062c0ea38d8
    https://github.com/scummvm/scummvm/commit/597316ff752a978a8b00da17a731a062c0ea38d8
Author: elasota (1137273+elasota at users.noreply.github.com)
Date: 2025-04-18T11:19:05-04:00

Commit Message:
VIDEO: Fix uninitialized memory access

Changed paths:
    video/qtvr_decoder.cpp


diff --git a/video/qtvr_decoder.cpp b/video/qtvr_decoder.cpp
index c8db8746ea6..5548471cc44 100644
--- a/video/qtvr_decoder.cpp
+++ b/video/qtvr_decoder.cpp
@@ -796,15 +796,14 @@ void QuickTimeDecoder::PanoTrackHandler::projectPanorama() {
 		float t = ((float)y + 0.5f) / (float)h;
 
 		float vector[3];
-		for (int v = 0; v < 3; v++) {
+		for (int v = 0; v < 3; v++)
 			vector[v] = cornerVectors[0][v] * (1.0f - t) + cornerVectors[1][v] * t;
 
-			float projectedX = vector[0] / vector[2];
-			float projectedY = vector[1] / vector[2];
+		float projectedX = vector[0] / vector[2];
+		float projectedY = vector[1] / vector[2];
 
-			sideEdgeXYInterpolators[y * 2 + 0] = projectedX / maxProjectedX;
-			sideEdgeXYInterpolators[y * 2 + 1] = (projectedY - minProjectedY) / (maxProjectedY - minProjectedY);
-		}
+		sideEdgeXYInterpolators[y * 2 + 0] = projectedX / maxProjectedX;
+		sideEdgeXYInterpolators[y * 2 + 1] = (projectedY - minProjectedY) / (maxProjectedY - minProjectedY);
 	}
 
 	const bool isWidthOdd = ((w % 2) == 1);




More information about the Scummvm-git-logs mailing list