[Scummvm-git-logs] scummvm master -> 074ea2b3a58177b39dfe0fbb8eee68203a8e295d

[sluicebox]

This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://api.github.com/repos/scummvm/scummvm .

Summary:
074ea2b3a5 SCI: Add KQ4 demo script patch comment


Commit: 074ea2b3a58177b39dfe0fbb8eee68203a8e295d
    https://github.com/scummvm/scummvm/commit/074ea2b3a58177b39dfe0fbb8eee68203a8e295d
Author: sluicebox (22204938+sluicebox at users.noreply.github.com)
Date: 2025-04-29T12:05:53-07:00

Commit Message:
SCI: Add KQ4 demo script patch comment

Changed paths:
    engines/sci/engine/script_patches.cpp


diff --git a/engines/sci/engine/script_patches.cpp b/engines/sci/engine/script_patches.cpp
index ff29d3f4d3f..e397b4e215e 100644
--- a/engines/sci/engine/script_patches.cpp
+++ b/engines/sci/engine/script_patches.cpp
@@ -26428,6 +26428,10 @@ void ScriptPatcher::processScript(uint16 scriptNr, SciSpan<byte> scriptData) {
 					enablePatch(signatureTable, "missing waterfall view");
 				}
 				if (!g_sci->isDemo()) {
+					// Signature matches kq4 demo, which would be okay, except
+					// that the demo does not include a selector table.
+					// The patcher does not validate this, so it creates an
+					// invalid instruction when processing PATCH_SELECTOR16.
 					enablePatch(signatureTable, "ride unicorn at night");
 				}
 				break;