[Scummvm-git-logs] scummvm master -> f14d54cd18647cf3d72b345ecdef9a523791ac16

[dwatteau]

This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://api.github.com/repos/scummvm/scummvm .

Summary:
f14d54cd18 CONFIGURE: COMMON: Document which systems require C++11 compat code


Commit: f14d54cd18647cf3d72b345ecdef9a523791ac16
    https://github.com/scummvm/scummvm/commit/f14d54cd18647cf3d72b345ecdef9a523791ac16
Author: Donovan Watteau (contrib at dwatteau.fr)
Date: 2025-08-12T16:54:00+02:00

Commit Message:
CONFIGURE: COMMON: Document which systems require C++11 compat code

Checked against the current riscos and macosx-i386 buildbot targets (for
more context about the macOS < 10.9 case, see also GH-2490 PR).

(Also simplify that comment of mine regarding Gold, while there.)

Changed paths:
    common/scummsys.h
    configure


diff --git a/common/scummsys.h b/common/scummsys.h
index cf6b5e3e1b4..744c3c483f4 100644
--- a/common/scummsys.h
+++ b/common/scummsys.h
@@ -482,7 +482,8 @@
 #endif
 
 //
-// std::nullptr_t when this type is not available
+// std::nullptr_t when unavailable (e.g. the compiler supports C++11,
+// but the standard library is older and has incomplete C++11 support)
 //
 #if defined(NO_CXX11_NULLPTR_T)
 namespace std {
@@ -491,8 +492,8 @@ namespace std {
 #endif
 
 //
-// std::initializer_list
-// Provide replacement when not available
+// std::initializer_list when unavailable (e.g. the compiler supports C++11,
+// but the standard library is older and has incomplete C++11 support)
 //
 #if defined(NO_CXX11_INITIALIZER_LIST)
 namespace std {
diff --git a/configure b/configure
index ce581e09fb3..0d2831fe3b8 100755
--- a/configure
+++ b/configure
@@ -2509,8 +2509,9 @@ fi
 # Additional tests for C++11 features that may not be present
 #
 
-# Check if initializer list is available
-echo_n "Checking if C++11 initializer list is available... "
+# Check if initializer_list is available (e.g. missing from macOS < 10.9,
+# when targeting system libstdc++ which had incomplete C++11 support)
+echo_n "Checking if C++11 initializer_list is available... "
 cat > $TMPC << EOF
 #include <initializer_list>
 #include <cstddef>
@@ -2529,7 +2530,8 @@ else
 	define_in_config_if_yes yes 'NO_CXX11_INITIALIZER_LIST'
 fi
 
-# Check if std::nullptr_t is available
+# Check if std::nullptr_t is available (e.g. missing from macOS < 10.9,
+# when targeting system libstdc++ which had incomplete C++11 support)
 echo_n "Checking if C++11 std::nullptr_t is available... "
 cat > $TMPC << EOF
 #include <cstddef>
@@ -2546,7 +2548,8 @@ else
 	define_in_config_if_yes yes 'NO_CXX11_NULLPTR_T'
 fi
 
-# Check if alignas and alignof are available
+# Check if alignas and alignof are available (e.g. GCC 4.7 as used for
+# RISC OS, while the feature was added in GCC 4.8)
 echo_n "Checking if C++11 alignas and alignof keywords are available... "
 cat > $TMPC << EOF
 #include <stddef.h>
@@ -2642,8 +2645,8 @@ fi
 # given (and then you're on your own).
 if $LD $LDFLAGS -Wl,--version 2>/dev/null | grep -q -e 'GNU gold'; then
 	# Trying to help systems where Gold may (unwisely) be the default;
-	# thus we only try to provide a GNU LD (BFD) fallback in that case,
-	# since it appears to only impact some (past?) GNU systems anyway.
+	# we only try to provide a GNU LD (BFD) fallback in that case, as
+	# it appears this would only impact older GNU systems anyway.
 	if test "$_gold" != yes && $LD $LDFLAGS -fuse-ld=bfd -Wl,--version >/dev/null 2>&1; then
 		append_var LDFLAGS -fuse-ld=bfd
 	else