[Scummvm-git-logs] scummvm branch-3-0 -> cd1d60ceb0f7a3cccb28f42185e3e989e93fe001

sluicebox noreply at scummvm.org
Wed Dec 10 19:28:37 UTC 2025


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://api.github.com/repos/scummvm/scummvm .

Summary:
cd1d60ceb0 PRIVATE: Fix phone clip order (again)


Commit: cd1d60ceb0f7a3cccb28f42185e3e989e93fe001
    https://github.com/scummvm/scummvm/commit/cd1d60ceb0f7a3cccb28f42185e3e989e93fe001
Author: sluicebox (22204938+sluicebox at users.noreply.github.com)
Date: 2025-12-10T11:28:06-08:00

Commit Message:
PRIVATE: Fix phone clip order (again)

I fixed this in 2af73137ff0c296964f287b37447b54c38d22251

Then I reintroduced it in 2a75bf3c8d747c9b11ad1e8b3cb7e4ae8a66df1e

Oops!

Changed paths:
    engines/private/private.cpp


diff --git a/engines/private/private.cpp b/engines/private/private.cpp
index a093ebcf75c..6f985201e28 100644
--- a/engines/private/private.cpp
+++ b/engines/private/private.cpp
@@ -1663,8 +1663,7 @@ void PrivateEngine::addPhone(const Common::String &name, bool once, int startInd
 				SWAP<Common::String>(newPhone.sounds[i], newPhone.sounds[n]);
 			}
 		}
-		// add to front of list; calls occur in reverse order
-		_phones.push_front(newPhone);
+		_phones.push_back(newPhone);
 	} else {
 		// update an available phone clip's state if its sounds haven't been played yet
 		if (phone->soundIndex < phone->sounds.size()) {




More information about the Scummvm-git-logs mailing list