[Scummvm-git-logs] scummvm branch-3-0 -> 311a54c0ebce8c8294b32d3011c4e3cdb4e2650f

[antoniou79]

This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://api.github.com/repos/scummvm/scummvm .

Summary:
311a54c0eb HDB: Prevent truncating dialog text to 128 chars


Commit: 311a54c0ebce8c8294b32d3011c4e3cdb4e2650f
    https://github.com/scummvm/scummvm/commit/311a54c0ebce8c8294b32d3011c4e3cdb4e2650f
Author: antoniou79 (a.antoniou79 at gmail.com)
Date: 2025-12-29T15:13:21+02:00

Commit Message:
HDB: Prevent truncating dialog text to 128 chars

Also fix a strlcpy command that had a size parameter greater than the target buffer size (128 vs 64) for _dialogInfo.title

The truncated dialog text can be seen as early as the first level / map, after delivering the scattered letters to the mailbox and talking to the guy next to it.
Another instance, again in the first map is when reading the tablet(?) next to the locked fridge in the mess hall.

The commit that originally set the truncate size to 128 was https://github.com/scummvm/scummvm/commit/16f1ff13bc8a123c691f2ec3c833c0bf696ed100 "HDB: Use Common::strlcpy() everywhere".

Changed paths:
    engines/hdb/window.cpp


diff --git a/engines/hdb/window.cpp b/engines/hdb/window.cpp
index 1458548d820..9b0184522cf 100644
--- a/engines/hdb/window.cpp
+++ b/engines/hdb/window.cpp
@@ -628,11 +628,11 @@ void Window::openDialog(const char *title, int tileIndex, const char *string, in
 	_dialogInfo.luaMore[0] = 0;
 
 	_dialogInfo.tileIndex = tileIndex;
-	Common::strlcpy(_dialogInfo.title, title, 128);
+	Common::strlcpy(_dialogInfo.title, title, 64);
 	_dialogInfo.active = true;
 
 	// This could need to be truncated
-	Common::strlcpy(_dialogInfo.string, string, 128);
+	Common::strlcpy(_dialogInfo.string, string, 160);
 
 	int e1, e2, e3, e4;
 	g_hdb->_gfx->getTextEdges(&e1, &e2, &e3, &e4);