[Scummvm-git-logs] scummvm master -> b1301e4fc5a708b9f1ae06322c1e5d6da843421c

sev- noreply at scummvm.org
Fri Feb 21 12:58:27 UTC 2025


This automated email contains information about 2 new commits which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
b3d390e358 DIRECTOR: XTRAS: Filter out dsSetLoop with loops > 1 only, in DirectSound Xtra
b1301e4fc5 VIDEO: QTVR: Catch only navg hostpots as unprocessed


Commit: b3d390e3586c260d553f3174034a3d27c7b2ba7d
    https://github.com/scummvm/scummvm/commit/b3d390e3586c260d553f3174034a3d27c7b2ba7d
Author: Eugene Sandulenko (sev at scummvm.org)
Date: 2025-02-21T13:55:31+01:00

Commit Message:
DIRECTOR: XTRAS: Filter out dsSetLoop with loops > 1 only, in DirectSound Xtra

Changed paths:
    engines/director/lingo/xtras/directsound.cpp


diff --git a/engines/director/lingo/xtras/directsound.cpp b/engines/director/lingo/xtras/directsound.cpp
index e198d397955..50d151056f0 100644
--- a/engines/director/lingo/xtras/directsound.cpp
+++ b/engines/director/lingo/xtras/directsound.cpp
@@ -303,7 +303,19 @@ XOBJSTUB(DirectsoundXtra::m_dsSetPan, 0)
 XOBJSTUB(DirectsoundXtra::m_dsGetPosition, 0)
 XOBJSTUB(DirectsoundXtra::m_dsSetPosition, 0)
 XOBJSTUB(DirectsoundXtra::m_dsGetLoop, 0)
-XOBJSTUB(DirectsoundXtra::m_dsSetLoop, 0)
+
+void DirectsoundXtra::m_dsSetLoop(int nargs) {
+	ARGNUMCHECK(2);
+
+	int loops = g_lingo->pop().asInt();
+	int id = parseId(g_lingo->pop().asString());
+
+	if (id == -1)
+		return;
+
+	if (loops > 1)
+		warning("STUB: DirectsoundXtra::m_dsSetLoop(\"DSoundXtra:%d\", %d)", id, loops);
+}
 
 void DirectsoundXtra::m_dsIsPlaying(int nargs) {
 	ARGNUMCHECK(1);


Commit: b1301e4fc5a708b9f1ae06322c1e5d6da843421c
    https://github.com/scummvm/scummvm/commit/b1301e4fc5a708b9f1ae06322c1e5d6da843421c
Author: Eugene Sandulenko (sev at scummvm.org)
Date: 2025-02-21T13:58:15+01:00

Commit Message:
VIDEO: QTVR: Catch only navg hostpots as unprocessed

Changed paths:
    video/qtvr_decoder.cpp


diff --git a/video/qtvr_decoder.cpp b/video/qtvr_decoder.cpp
index de0abc5dfe8..46b36b3c81c 100644
--- a/video/qtvr_decoder.cpp
+++ b/video/qtvr_decoder.cpp
@@ -1357,9 +1357,12 @@ void QuickTimeDecoder::updateQTVRCursor(int16 x, int16 y) {
 			hsUp = kCursorPanoLinkUp;
 			break;
 
+		case MKTAG('n','a','v','g'):
+			debug(3, "Hotspot type: %s", tag2str((uint32)hsType));
+			// TODO FIXME: Implement
+			// fallthrough
+
 		default:
-			if (hsType !=  MKTAG('u','n','d','f'))
-				debug(3, "Hotspot type: %s", tag2str((uint32)hsType));
 			hsOver = kCursorPanoObjOver;
 			hsDown = kCursorPanoObjDown;
 			hsUp = kCursorPanoObjUp;




More information about the Scummvm-git-logs mailing list