[Scummvm-git-logs] scummvm master -> 1413a8318c97b7e826c7fcd040b5e26af7cc94c7

[bluegr]

This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
1413a8318c IMAGE: Fix 24bpp PCX image decoding.


Commit: 1413a8318c97b7e826c7fcd040b5e26af7cc94c7
    https://github.com/scummvm/scummvm/commit/1413a8318c97b7e826c7fcd040b5e26af7cc94c7
Author: Matthew Jimenez (matthew.jimenez at outlook.com)
Date: 2025-02-28T02:57:34+02:00

Commit Message:
IMAGE: Fix 24bpp PCX image decoding.
The RGB planes were flipped and TESTBED image decoder tests revealed this bug. AGS is the only engine that allows for 24bpp PCX image, but an example game is currently unknown.

Changed paths:
    image/pcx.cpp


diff --git a/image/pcx.cpp b/image/pcx.cpp
index e596d21c800..7d466715a63 100644
--- a/image/pcx.cpp
+++ b/image/pcx.cpp
@@ -120,9 +120,9 @@ bool PCXDecoder::loadStream(Common::SeekableReadStream &stream) {
 			decodeRLE(stream, scanLine, bytesPerscanLine, compressed);
 
 			for (x = 0; x < width; x++) {
-				byte b = scanLine[x];
+				byte r = scanLine[x];
 				byte g = scanLine[x +  bytesPerLine];
-				byte r = scanLine[x + (bytesPerLine << 1)];
+				byte b = scanLine[x + (bytesPerLine << 1)];
 				uint32 color = format.RGBToColor(r, g, b);
 
 				*((uint32 *)dst) = color;