[Scummvm-git-logs] scummvm master -> 6a0d871b4226a2143de2c36c0e4f0e2b458b5de5

eriktorbjorn noreply at scummvm.org
Wed Jan 1 13:39:13 UTC 2025


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
6a0d871b42 SCUMM: MACGUI: Fix comment typo spotted by raziel


Commit: 6a0d871b4226a2143de2c36c0e4f0e2b458b5de5
    https://github.com/scummvm/scummvm/commit/6a0d871b4226a2143de2c36c0e4f0e2b458b5de5
Author: Torbjörn Andersson (eriktorbjorn at users.sourceforge.net)
Date: 2025-01-01T14:38:36+01:00

Commit Message:
SCUMM: MACGUI: Fix comment typo spotted by raziel

There was also some text I could have sworn I wrote, but must have
accidentally thrown away.

Changed paths:
    engines/scumm/macgui/macgui_v6.h


diff --git a/engines/scumm/macgui/macgui_v6.h b/engines/scumm/macgui/macgui_v6.h
index 6fdcef6c2d3..a14a822440c 100644
--- a/engines/scumm/macgui/macgui_v6.h
+++ b/engines/scumm/macgui/macgui_v6.h
@@ -225,13 +225,16 @@ private:
 		// There are several possible approaches to picking the node to
 		// reduce. Picking the one with the largest number of pixels
 		// may leave more color for fine details. Picking the one with
-		// the smallest may will sacrifice detail, but may preserve
-		// subtle gradations in large areas. This picks the first one,
-		// i.e. the most recently inserted one, so it's pretty random.
+		// the smallest number may sacrifice detail, but preserve subtle
+		// gradations in large areas. This just picks the first one,
+		// i.e. the most recently inserted one, so it's pretty random
+		// which may be good on average.
 		//
-		// On the contrary, it stated that "any new colors whose path
-		// through the tree take them through [a node that was turned
-		// into a leaf] now stop here".
+		// Once a subtree has been pruned, it will no longer grow back.
+		// It seems to me it should be possible to allow it to, but the
+		// article doesn't mention it. On the contrary, it states that
+		// "any new colors whose path through the tree take them
+		// through [a node that was turned into a leaf] now stop here".
 
 		OctreeNode *node = _reduceList[level];
 		_reduceList[level] = _reduceList[level]->nextNode;




More information about the Scummvm-git-logs mailing list