[Scummvm-git-logs] scummvm master -> 08e675ce6e5f94f93764cf6b301c46f47b3661de

[eriktorbjorn]

This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
08e675ce6e SCUMM: MACGUI: Disable "About" screen for Maniac Mansion.


Commit: 08e675ce6e5f94f93764cf6b301c46f47b3661de
    https://github.com/scummvm/scummvm/commit/08e675ce6e5f94f93764cf6b301c46f47b3661de
Author: Torbjörn Andersson (eriktorbjorn at users.sourceforge.net)
Date: 2025-01-08T07:50:21+01:00

Commit Message:
SCUMM: MACGUI: Disable "About" screen for Maniac Mansion.

There wasn't one in the original. Apparently Aaron Giles never made one.

Changed paths:
    engines/scumm/macgui/macgui_v6.cpp


diff --git a/engines/scumm/macgui/macgui_v6.cpp b/engines/scumm/macgui/macgui_v6.cpp
index faa02487ca5..f66153ef4a7 100644
--- a/engines/scumm/macgui/macgui_v6.cpp
+++ b/engines/scumm/macgui/macgui_v6.cpp
@@ -429,6 +429,15 @@ MacGuiImpl::MacImageSlider *MacV6Gui::addSlider(MacDialogWindow *window, int x,
 }
 
 void MacV6Gui::runAboutDialog() {
+	// While there is a menu item for a Maniac Mansion credits screen, it
+	// doesn't do anything.
+	//
+	// "I was probably exhausted from hand-placing all the letters on the
+	// DOTT credits screen to make one for Maniac." -- Aaron Giles,
+	// December 30, 2024.
+	if (_vm->_game.id == GID_MANIAC)
+		return;
+
 	if (_vm->_game.features & GF_DEMO) {
 		// HACK: Use the largest bounds as default for unknown demos
 		// It would be nice if we could figure these out automatically