[Scummvm-git-logs] scummvm master -> 686cdd13719b92554fa46b264c512ca7deec7a96

[spleen1981]

This automated email contains information about 2 new commits which have been
pushed to the 'scummvm' repo located at https://api.github.com/repos/scummvm/scummvm .

Summary:
ba9da5d8e4 NANCY: skip unneeded Screen::Screen() constructor call
686cdd1371 AWE: BUILD: remove detection.o from MODULE_OBJS


Commit: ba9da5d8e44e289679c318da8589b151b1c7e72e
    https://github.com/scummvm/scummvm/commit/ba9da5d8e44e289679c318da8589b151b1c7e72e
Author: Giovanni Cascione (ing.cascione at gmail.com)
Date: 2025-07-03T01:25:14+02:00

Commit Message:
NANCY: skip unneeded Screen::Screen() constructor call
That call would store a dirty rectangle potentially wider than engine target screen size (640x480), in cases where g_system->getWidth(), g_system->getHeight() are bigger for any reason, causing assertions failures on rectangle rendering to screen later.

Changed paths:
    engines/nancy/graphics.cpp


diff --git a/engines/nancy/graphics.cpp b/engines/nancy/graphics.cpp
index a8255b2b95e..ca3e640640b 100644
--- a/engines/nancy/graphics.cpp
+++ b/engines/nancy/graphics.cpp
@@ -38,7 +38,8 @@ GraphicsManager::GraphicsManager() :
 	_screenPixelFormat(2, 5, 6, 5, 0, 11, 5, 0, 0),
 	_clut8Format(Graphics::PixelFormat::createFormatCLUT8()),
 	_transparentPixelFormat(4, 8, 8, 8, 8, 8, 16, 24, 0),
-	_isSuppressed(false) {}
+	_isSuppressed(false),
+	_screen(640, 480, _screenPixelFormat){}
 
 void GraphicsManager::init() {
 	auto *bsum = GetEngineData(BSUM);
@@ -54,7 +55,6 @@ void GraphicsManager::init() {
 	}
 
 	initGraphics(640, 480, &_screenPixelFormat);
-	_screen.create(640, 480, _screenPixelFormat);
 	_screen.setTransparentColor(getTransColor());
 	_screen.clear();
 


Commit: 686cdd13719b92554fa46b264c512ca7deec7a96
    https://github.com/scummvm/scummvm/commit/686cdd13719b92554fa46b264c512ca7deec7a96
Author: Giovanni Cascione (ing.cascione at gmail.com)
Date: 2025-07-03T01:25:27+02:00

Commit Message:
AWE: BUILD: remove detection.o from MODULE_OBJS
Ref to similar commit 3b17472f7d84e97abde0c1b00b5d01922f276771

Changed paths:
    engines/awe/module.mk


diff --git a/engines/awe/module.mk b/engines/awe/module.mk
index 82006121b5e..139662a52b6 100644
--- a/engines/awe/module.mk
+++ b/engines/awe/module.mk
@@ -5,7 +5,6 @@ MODULE_OBJS = \
 	awe.o \
 	aifc_player.o \
 	bitmap.o \
-	detection.o \
 	engine.o \
 	graphics_gl.o \
 	graphics_soft.o \