[Scummvm-git-logs] scummvm master -> a7a593e70c35239154fa2575ec80ce1e85957d03

[sev-]

This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://api.github.com/repos/scummvm/scummvm .

Summary:
a7a593e70c Revert "ENGINES: Prevent resource leak in ExtendedSavegameHeader. CID 1591629"


Commit: a7a593e70c35239154fa2575ec80ce1e85957d03
    https://github.com/scummvm/scummvm/commit/a7a593e70c35239154fa2575ec80ce1e85957d03
Author: Eugene Sandulenko (sev at scummvm.org)
Date: 2025-06-12T20:10:48+02:00

Commit Message:
Revert "ENGINES: Prevent resource leak in ExtendedSavegameHeader. CID 1591629"

This reverts commit 89e71ebec479a8b8291af9cd86ee11827d5670de.

Just as anticipated, this led to crashes.

Changed paths:
    engines/metaengine.cpp
    engines/metaengine.h


diff --git a/engines/metaengine.cpp b/engines/metaengine.cpp
index 8be8ef2bb8b..ec96298415b 100644
--- a/engines/metaengine.cpp
+++ b/engines/metaengine.cpp
@@ -208,14 +208,6 @@ bool MetaEngine::hasFeature(MetaEngineFeature f) const {
 //// Extended Saves
 /////////////////////////////////////////
 
-ExtendedSavegameHeader::~ExtendedSavegameHeader() {
-	if (thumbnail)
-		thumbnail->free();
-
-	delete thumbnail;
-}
-
-
 void MetaEngine::appendExtendedSave(Common::OutSaveFile *saveFile, uint32 playtime,
 		Common::String desc, bool isAutosave) {
 	appendExtendedSaveToStream(saveFile, playtime, desc, isAutosave);
diff --git a/engines/metaengine.h b/engines/metaengine.h
index ee145eecca1..116cd4c5491 100644
--- a/engines/metaengine.h
+++ b/engines/metaengine.h
@@ -111,8 +111,6 @@ struct ExtendedSavegameHeader {
 		thumbnail = nullptr;
 		isAutosave = false;
 	}
-
-	~ExtendedSavegameHeader();
 };
 
 /**