[Scummvm-git-logs] scummvm master -> 5df68254e4a271fbd5f3b93de4d7d117c2174639

sev- noreply at scummvm.org
Tue Mar 18 17:41:19 UTC 2025


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://github.com/scummvm/scummvm .

Summary:
5df68254e4 DIRECTOR: DEBUGGER: Generate unique table ids to prevent warnings.


Commit: 5df68254e4a271fbd5f3b93de4d7d117c2174639
    https://github.com/scummvm/scummvm/commit/5df68254e4a271fbd5f3b93de4d7d117c2174639
Author: BabaSambar (5.5.2005harsh at gmail.com)
Date: 2025-03-19T01:41:14+08:00

Commit Message:
DIRECTOR: DEBUGGER: Generate unique table ids to prevent warnings.

Changed paths:
    engines/director/debugger/dt-score.cpp


diff --git a/engines/director/debugger/dt-score.cpp b/engines/director/debugger/dt-score.cpp
index 1f1041ceffb..7ee269e82fc 100644
--- a/engines/director/debugger/dt-score.cpp
+++ b/engines/director/debugger/dt-score.cpp
@@ -616,13 +616,24 @@ void showChannels() {
 					ImGui::TableNextColumn();
 					ImGui::Text("%d (%s)", sprite._spriteType, spriteType2str(sprite._spriteType));
 					ImGui::TableNextColumn();
+					ImGui::PushID(i + 1);
 					ImGui::Text("%3d", sprite._foreColor); ImGui::SameLine();
 					ImGui::ColorButton("foreColor", convertColor(sprite._foreColor));
+					ImGui::PopID();
 					ImGui::TableNextColumn();
+					ImGui::PushID(i + 1);
 					ImGui::Text("%3d", sprite._backColor); ImGui::SameLine();
 					ImGui::ColorButton("backColor", convertColor(sprite._backColor));
+					ImGui::PopID();
 					ImGui::TableNextColumn();
-					displayScriptRef(sprite._scriptId);
+					// Check early for non integer script ids
+					if (sprite._scriptId.member) {
+						displayScriptRef(sprite._scriptId);
+					} else {
+						ImGui::PushID(i + 1);
+						ImGui::Selectable("  ");
+						ImGui::PopID();
+					}
 					ImGui::TableNextColumn();
 					ImGui::Text("0x%x", sprite._colorcode);
 					ImGui::TableNextColumn();




More information about the Scummvm-git-logs mailing list