[Scummvm-git-logs] scummvm master -> 55e7c59c3b94ed26d9ac1d2e3ac9e8a0efb4e881

[tag2015]

This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://api.github.com/repos/scummvm/scummvm .

Summary:
55e7c59c3b AGS: Engine: compatibility fix for "Trilby's Notes" not running FadeIn()


Commit: 55e7c59c3b94ed26d9ac1d2e3ac9e8a0efb4e881
    https://github.com/scummvm/scummvm/commit/55e7c59c3b94ed26d9ac1d2e3ac9e8a0efb4e881
Author: Walter Agazzi (walter.agazzi at protonmail.com)
Date: 2025-05-03T11:12:56+02:00

Commit Message:
AGS: Engine: compatibility fix for "Trilby's Notes" not running FadeIn()

This is a silly case, the game runs FadeOut() when changing from title screen
to main menu, but forgets to run FadeIn().
Somehow it accidentally worked in the older engine, because it had a strange
condition where the screen was not marked as "faded-out" in 8-bit games.

>From upstream 955f5ab76e136cac8cac866eeb8a9f42c7573e3d

Changed paths:
    engines/ags/engine/ac/global_screen.cpp


diff --git a/engines/ags/engine/ac/global_screen.cpp b/engines/ags/engine/ac/global_screen.cpp
index f38af739cce..05b5f66160c 100644
--- a/engines/ags/engine/ac/global_screen.cpp
+++ b/engines/ags/engine/ac/global_screen.cpp
@@ -143,6 +143,13 @@ void FadeOut(int sppd) {
 	sync_audio_playback();
 	fadeout_impl(sppd);
 	sync_audio_playback();
+
+	// Older engines did not mark the screen as "faded out" specifically for
+	// the 8-bit games, for unknown reasons. There's at least one game where
+	// this was accidentally useful, as it did not run FadeIn after FadeOut.
+	if ((_G(loaded_game_file_version) < kGameVersion_361) && _GP(game).color_depth == 1) {
+		_GP(play).screen_is_faded_out = 0;
+	}
 }
 
 void fadeout_impl(int spdd) {