[Scummvm-git-logs] scummvm master -> 2a1a0211e081dc72168336d7ba9a289abc822e77

lephilousophe noreply at scummvm.org
Thu May 29 15:58:58 UTC 2025


This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://api.github.com/repos/scummvm/scummvm .

Summary:
2a1a0211e0 GUI: Remove useless call to getTopDialog


Commit: 2a1a0211e081dc72168336d7ba9a289abc822e77
    https://github.com/scummvm/scummvm/commit/2a1a0211e081dc72168336d7ba9a289abc822e77
Author: Le Philousophe (lephilousophe at users.noreply.github.com)
Date: 2025-05-29T17:58:27+02:00

Commit Message:
GUI: Remove useless call to getTopDialog

activeDialog is guaranteed to be getTopDialog result.

Changed paths:
    gui/gui-manager.cpp


diff --git a/gui/gui-manager.cpp b/gui/gui-manager.cpp
index 26301a9733f..d0a1d3aa458 100644
--- a/gui/gui-manager.cpp
+++ b/gui/gui-manager.cpp
@@ -676,7 +676,7 @@ void GuiManager::runLoop() {
 	// called we cannot rely on catching EVENT_QUIT in the event loop above,
 	// since it would only catch it for the top run loop.
 	if ((eventMan->shouldQuit() || (g_engine && eventMan->shouldReturnToLauncher())) && activeDialog == getTopDialog()) {
-		getTopDialog()->close();
+		activeDialog->close();
 		emptyTrash(activeDialog);
 	}
 




More information about the Scummvm-git-logs mailing list