[Scummvm-git-logs] scummvm-web master -> 583f1f427827554081e70f12adb833b43ecf2f89

lephilousophe noreply at scummvm.org
Sat May 31 12:12:09 UTC 2025


This automated email contains information about 2 new commits which have been
pushed to the 'scummvm-web' repo located at https://api.github.com/repos/scummvm/scummvm-web .

Summary:
818cc97e18 Revert "DUMPER-COMPANION: Force generate DOS comaptible zip files"
583f1f4278 WEB: Don't render recommended download badge if there are none


Commit: 818cc97e18129470054fe47b17cd9d3184b54692
    https://github.com/scummvm/scummvm-web/commit/818cc97e18129470054fe47b17cd9d3184b54692
Author: Le Philousophe (lephilousophe at users.noreply.github.com)
Date: 2025-05-31T14:11:39+02:00

Commit Message:
Revert "DUMPER-COMPANION: Force generate DOS comaptible zip files"

This reverts commit ec2e54fe06d13c7b562a79ed1334607c6df3957a.
zip.js has been upgraded and this workaround is not needed anymore.

Changed paths:
    dumper-companion/src/Dumper.tsx


diff --git a/dumper-companion/src/Dumper.tsx b/dumper-companion/src/Dumper.tsx
index 4dd24526..0037e78b 100644
--- a/dumper-companion/src/Dumper.tsx
+++ b/dumper-companion/src/Dumper.tsx
@@ -152,7 +152,6 @@ export default class Dumper extends Component<Props, State> {
                 volume.dumpToZip(zipFS.root, this.state.lang, !this.state.unicode, this.state.forceMacBinary, this.log.bind(this));
                 const blob = await zipFS.exportBlob({
                     level: 0,
-                    msDosCompatible: true,
                     onprogress: (index, max) => {
                         const percent = Math.floor(index / max * 100);
                         this.updateDumpPercent(percent);


Commit: 583f1f427827554081e70f12adb833b43ecf2f89
    https://github.com/scummvm/scummvm-web/commit/583f1f427827554081e70f12adb833b43ecf2f89
Author: Le Philousophe (lephilousophe at users.noreply.github.com)
Date: 2025-05-31T14:11:39+02:00

Commit Message:
WEB: Don't render recommended download badge if there are none

This avoids warnings when accessing the invalid data.

Changed paths:
    templates/components/recommended_download.tpl


diff --git a/templates/components/recommended_download.tpl b/templates/components/recommended_download.tpl
index 8d798582..3340acea 100644
--- a/templates/components/recommended_download.tpl
+++ b/templates/components/recommended_download.tpl
@@ -1,4 +1,5 @@
-<div id="recommended-download" class="{($recommendedDownload) ? 'visible':'hidden'}">
+{if $recommendedDownload}
+<div id="recommended-download">
     <div class="subhead">{#downloadsBadge#}</div>
     <div class="subhead-content">
         <div id="downloadContainer">
@@ -10,4 +11,5 @@
         </div>
     </div>
 </div>
+{/if}
 <br>




More information about the Scummvm-git-logs mailing list