[Scummvm-git-logs] scummvm master -> 8b21436b1c67394e03ed9d2cf74b2db3ec06d0c2

[dwatteau]

This automated email contains information about 1 new commit which have been
pushed to the 'scummvm' repo located at https://api.github.com/repos/scummvm/scummvm .

Summary:
8b21436b1c BUILD: MACOS: Don't use posix_spawn() on any macOS version


Commit: 8b21436b1c67394e03ed9d2cf74b2db3ec06d0c2
    https://github.com/scummvm/scummvm/commit/8b21436b1c67394e03ed9d2cf74b2db3ec06d0c2
Author: Donovan Watteau (contrib at dwatteau.fr)
Date: 2025-10-04T22:01:52+02:00

Commit Message:
BUILD: MACOS: Don't use posix_spawn() on any macOS version

Quoting @ccawley2011, "OSystem_MacOSX uses a custom implementation
of openUrl() instead of posix_spawn()", meaning that the (unique)
posix_spawn() call has no purpose on this platform.

Disable its use on all macOS versions, not just Tiger.

Changed paths:
    configure


diff --git a/configure b/configure
index c1ad00f642d..b32844093bd 100755
--- a/configure
+++ b/configure
@@ -3008,6 +3008,8 @@ case $_host_os in
 		append_var LIBS "-framework Cocoa"
 		add_line_to_config_mk 'MACOSX = 1'
 		_seq_midi=no
+		# Custom openUrl() doesn't require it, and it's unavailable on 10.4 anyway
+		_has_posix_spawn=no
 
 		# Now we may have MacPorts or Fink installed
 		# Which put libraries and headers in non-standard places
@@ -3165,14 +3167,6 @@ EOF
 				fi
 			fi
 
-			# If one targets MacOS X 10.4, but uses a newer SDK, posix_spawn() may be
-			# found, but then it shouldn't be used, as the 10.4 libc doesn't have it.
-			# It's only used for openUrl(), and launching a web browser on such an old
-			# OS doesn't sound wise anyway.
-			if test "$_macos_min_version" -lt 1050 ; then
-				_has_posix_spawn=no
-			fi
-
 			# When building with SDK 10.14 or above, we cannot compile the 32 bits dock plugin
 			# Assume the SDK version is the same as the min version.
 			if test "$_macos_min_version" -gt 101399 ; then
@@ -4789,7 +4783,10 @@ if test "$_posix" = yes ; then
 	append_var DEFINES "-DPOSIX"
 	add_line_to_config_mk 'POSIX = 1'
 
-	echo_n "Checking if posix_spawn is supported... "
+	# So far, posix_spawn() is only used to provide openUrl() on POSIX
+	# systems. But some of them may already have their own openUrl()
+	# override, meaning that using posix_spawn() serves no purpose.
+	echo_n "Checking if posix_spawn is required and supported... "
 	if test "$_has_posix_spawn" != no ; then
 		cat > $TMPC << EOF
 #include <spawn.h>